Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AUTHORIZED_FETCH mode and WHITELIST_MODE #12856

Conversation

@ThibG
Copy link
Collaborator

ThibG commented Jan 13, 2020

No description provided.

@ThibG ThibG force-pushed the ThibG:documentation/fetch-mode-whitelist-mode-documentation branch from e30d1db to faaaaa0 Jan 13, 2020
@ThibG ThibG requested a review from Gargron Jan 18, 2020
@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Jan 21, 2020

Should this maybe be part of documentation instead? Since .env.production is auto-generated from mastodon:setup, a lot of people probably don't look into the sample file like they used to. It feels weird to document functionality in bash comments in an env file.

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Jan 21, 2020

Well, summarily describing flags in the config file sample is helpful and common practice.
But I guess a shorter description of what they do and a proper entry in the documentation would be best.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Jan 21, 2020

A link to the anchor in documentation would be perfect, actually

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Jan 22, 2020

Updated by shortening significantly the description and linking to the docs

@Gargron Gargron merged commit 27f9aa3 into tootsuite:master Jan 22, 2020
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.