Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gemfile.lock #12995

Merged
merged 4 commits into from Jan 28, 2020
Merged

Fix Gemfile.lock #12995

merged 4 commits into from Jan 28, 2020

Conversation

@ThibG
Copy link
Collaborator

ThibG commented Jan 28, 2020

No description provided.

…atch Gemfile.lock issues
@ThibG ThibG changed the title Fix Gemfile.lock and change CI to catch such issues Fix Gemfile.lock Jan 28, 2020
@hinaloe

This comment has been minimized.

Copy link
Contributor

hinaloe commented Jan 28, 2020

bundler said that: [DEPRECATED] The `--deployment` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set deployment 'true'`, and stop using this flag

@ThibG ThibG marked this pull request as ready for review Jan 28, 2020
@ThibG ThibG force-pushed the ThibG:fixes/dependencies branch from 50ce49c to 3aced05 Jan 28, 2020
@shleeable

This comment has been minimized.

Copy link
Contributor

shleeable commented Jan 28, 2020

lgtm. Sorry again.

@Gargron Gargron merged commit 1051de0 into tootsuite:master Jan 28, 2020
2 checks passed
2 checks passed
build-and-test Workflow: build-and-test
Details
codeclimate All good!
Details
renatolond added a commit to masto-donte-com-br/mastodon that referenced this pull request Jan 31, 2020
PR tootsuite#12995 changed circleci configs to set clean to true, according to
docs, this flag makes bundler run bundler clean after each install.
bundle clean by itself raises an error in circleci about cleaning all
gems.
renatolond added a commit to masto-donte-com-br/mastodon that referenced this pull request Jan 31, 2020
PR tootsuite#12995 changed circleci configs to set clean to true, according to
docs, this flag makes bundler run bundler clean after each install.
bundle clean by itself raises an error in circleci about cleaning all
gems.
renatolond added a commit to masto-donte-com-br/mastodon that referenced this pull request Jan 31, 2020
PR tootsuite#12995 changed circleci configs for bundler. Running bundle clean
without a path raises an error about cleaning all of the system gems.
This adds back the path used before 12995.
renatolond added a commit to masto-donte-com-br/mastodon that referenced this pull request Jan 31, 2020
PR tootsuite#12995 changed circleci configs for bundler. Running bundle clean
without a path raises an error about cleaning all of the system gems.
This adds back the path used before 12995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.