Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom icon for private boosts #14380

Merged
merged 1 commit into from Jul 23, 2020

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Jul 23, 2020

It doesn't really add any info, it just makes it easier to distinguish followers-only posts from public/unlisted ones.

It might avoid people freaking out thinking they have posted something in public/unlisted, especially people coming from pre-3.2.0, where the boost icon was replaced by a lock.

Peek 23-07-2020 15-36

@Gargron Gargron merged commit 9564731 into mastodon:master Jul 23, 2020
@brawaru
Copy link
Contributor

brawaru commented Jul 25, 2020

I've noticed this change and was really confused before I got to GitHub and seen this PR. I don't really think this is a good change, boosting your post does not introduce any new functionality to have different icon and that lock is just confusing. I asked a few friends and while they've successfully got what boost button means, what its colored and 🚫 variants mean, they haven't understood what one with the 🔒 does, and the thing is — it does nothing different from default variant, and they said it's “not that intuitive” just to be polite.

@ClearlyClaire
Copy link
Contributor Author

ClearlyClaire commented Jul 25, 2020

Uh. It's something I've been asked for a while in glitch-soc (which has displayed the normal boost icon on private toots for a long while, unlike Mastodon where this is new with 3.2.0), and I've only received positive feedback before yours.

@Gargron
Copy link
Member

Gargron commented Jul 25, 2020

Would it be a fair assumption to say that people who use glitch-soc are more familiar with the technical workings of Mastodon? That could account for the disparity in feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants