New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.0 support #16046
Add Ruby 3.0 support #16046
Conversation
6fa9112
to
847d698
Compare
Reading on the
I think it's a bit early to really bother for now. As far as I understand, the idea is that Ruby's scheduler will eventually be able to schedule fibers, automatically yielding control to another fiber whenever hitting a supported IO operation, which I assume a good replacement to the pattern I used would eventually be to use fibers ourselves and have Ruby deal with them, but for now, I think it is fine using |
e1a05e9
to
62b6b25
Compare
Also improve the Terrapin monkey-patch for the stderr/stdout issue.
db425dc
to
503a2d5
Compare
503a2d5
to
abf7873
Compare
Late to the party, but a fresh install of 3.4.1 with a modified I had to add |
* Fix issues with POSIX::Spawn, Terrapin and Ruby 3.0 Also improve the Terrapin monkey-patch for the stderr/stdout issue. * Fix keyword argument handling throughout the codebase * Monkey-patch Paperclip to fix keyword arguments handling in validators * Change validation_extensions to please CodeClimate * Bump microformats from 4.2.1 to 4.3.1 * Allow Ruby 3.0 * Add Ruby 3.0 test target to CircleCI * Add test for admin dashboard warnings * Fix admin dashboard warnings on Ruby 3.0
posix-spawn
executing the child process with non-blocking file descriptors forstdout
andstderr
when using Ruby 3.0 (also fixed another issue not related to Ruby 3.0)Actually running it on Ruby 3.0 is still not possible after that PR because one dependency (microformats
) does not advertise Ruby 3.0 compatibility.