Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for boosting depends on toot visibility (#1394) #1754

Merged
merged 7 commits into from Apr 23, 2017

Conversation

Projects
None yet
4 participants
@expenses
Copy link
Contributor

expenses commented Apr 14, 2017

Fix for #1394. Looks like:
example
Note that this adds a new localization string.

@thurloat

This comment has been minimized.

Copy link
Contributor

thurloat commented Apr 14, 2017

I had a new user point this out to me today, came to log and issue and it's already been logged and a fix ready to go.

You all rock.

@thurloat

This comment has been minimized.

Copy link
Contributor

thurloat commented Apr 14, 2017

There's an inconsistency between your default translation, and the English translation.

app/assets/javascripts/components/locales/en.jsx calls it a Toot, though there are other translations in the file that refer to toots as Posts. i.e. "compose_form.privacy_disclaimer".

app/assets/javascripts/components/components/status_action_bar.jsx calls it a Post.

@expenses

This comment has been minimized.

Copy link
Contributor Author

expenses commented Apr 15, 2017

@thurloat I think they're meant to be different.

@yiskah

yiskah approved these changes Apr 23, 2017

Copy link
Contributor

yiskah left a comment

This looks to add a useful a11y feature

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Apr 23, 2017

@expenses @thurloat For the record, the official UI does not refer to any items as "toots". They are "statuses" in most places, and "posts" in places where it needs to be shorter. Only the "publish" button is called "toot". This is deliberate, the UI can't get too silly.

@@ -119,6 +119,7 @@ const en = {
"status.mention": "Mention @{name}",
"status.open": "Expand this status",
"status.reblog": "Boost",
"status.cannot_reblog": "This toot cannot be boosted",

This comment has been minimized.

Copy link
@Gargron

Gargron Apr 23, 2017

Member

Change this to status and this is good to go. Sorry it took so long

This comment has been minimized.

Copy link
@expenses

expenses Apr 23, 2017

Author Contributor

.. And done!

@Gargron Gargron merged commit 9cd20a7 into tootsuite:master Apr 23, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate no new or fixed issues
Details

Gargron added a commit that referenced this pull request Apr 26, 2017

@expenses expenses deleted the expenses:change-boost-tooltips branch Apr 28, 2017

seefood added a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017

Tooltip for boosting depends on toot visibility (tootsuite#1394) (too…
…tsuite#1754)

* Made tooltip for boosting depend on visibility

* Removed spaces that were added in merge conflict resolution

* Try again :P

* Added missing bracket

* Changed 'toot' to 'status'

seefood added a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017

y0t4 added a commit to y0t4/mastodon that referenced this pull request Apr 29, 2017

Tooltip for boosting depends on toot visibility (tootsuite#1394) (too…
…tsuite#1754)

* Made tooltip for boosting depend on visibility

* Removed spaces that were added in merge conflict resolution

* Try again :P

* Added missing bracket

* Changed 'toot' to 'status'

y0t4 added a commit to y0t4/mastodon that referenced this pull request Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.