New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regex filter #1845

Merged
merged 4 commits into from Apr 16, 2017

Conversation

Projects
None yet
3 participants
@abcang
Collaborator

abcang commented Apr 15, 2017

Fixed a bug that regex filter matches HTML tag generated by simple_format.

  • completion of line breaks
  • tag deletion
  • unescape
@Gargron

This comment has been minimized.

Member

Gargron commented Apr 15, 2017

Have you noticed if doing the DOM parsing in a loop makes the columns noticeably laggier?

@abcang

This comment has been minimized.

Collaborator

abcang commented Apr 15, 2017

I confirmed that it will be delayed.
I would like to think of another way.
Thank you.

@Gargron

This comment has been minimized.

Member

Gargron commented Apr 15, 2017

@abcang Perhaps something like an extra reducer where you would store the indexable plaintext at time of entry, and then that would become part of the status object in the container and could be filtered-on.

Don't worry if this sounds too complicated, I might do it later...

@abcang

This comment has been minimized.

Collaborator

abcang commented Apr 16, 2017

Yes, I think so too.
And instead of deleting tags and escaping on the client side, I'd like to change the server side to send raw content.

@abcang

This comment has been minimized.

Collaborator

abcang commented Apr 16, 2017

I changed to send raw content on the server side.
But, in the case of remote toot, I noticed that escaped content was sent.
Therefore, I am planning to return to the process to escape on the client side.

@abcang

This comment has been minimized.

Collaborator

abcang commented Apr 16, 2017

I changed it to unescape in reducer.
Therefore, the lag problem was solved.

@Gargron Gargron merged commit 90760ea into tootsuite:master Apr 16, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alpaca-tc alpaca-tc deleted the pixiv:fix/regex_filter branch Apr 24, 2017

Nyoho pushed a commit to Nyoho/mastodon that referenced this pull request Apr 25, 2017

fix regex filter (tootsuite#1845)
* fix regex filter

* fixed br to linebreak and, stlip tags.

* change to send raw content

* changed to unescape in reducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment