New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate queue for RemovalWorker #1929

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@walf443
Contributor

walf443 commented Apr 16, 2017

When some user that has many followers remove a status, many RemovalWorker job generated.
It make slow consuming default queue tasks.

@ineffyble

This comment has been minimized.

Collaborator

ineffyble commented Apr 16, 2017

Are you able to make a pull request against the documentation repo and update all the examples there to include the extra queue?

This is a bit of a breaking change, so not sure how we could roll it out easily.

@ineffyble ineffyble requested a review from Gargron Apr 16, 2017

@Gargron

This comment has been minimized.

Member

Gargron commented Apr 16, 2017

Yeah, no, this is not an easy change to do at all! When I had to introduce the pull queue I was getting reports of admins who didn't realize it, for almost a week. Besides, adding a new queue by itself won't change much unless you're running independent Sidekiq processes for specific queues.

Other solutions:

  • Make RemoveStatusService run faster
  • Move it to an existing non-default queue
@walf443

This comment has been minimized.

Contributor

walf443 commented Apr 18, 2017

OK. I'll research RemoveStatusService to work more fast.

@walf443 walf443 closed this Apr 18, 2017

@alpaca-tc alpaca-tc deleted the pixiv:fix/change_removal_worker_queue_to_remove branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment