Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check @recipient.user at the first #1939

Merged
merged 2 commits into from Apr 16, 2017

Conversation

Projects
None yet
3 participants
@alpaca-tc
Copy link
Contributor

commented Apr 16, 2017

L44 are not working if @recepient.user is nil.


Fixes NoMethodError.

*A* `NoMethodError` *occured in background*
Exception
----------------
undefined method 'settings' for nil:NilClass

Backtrace
----------------
app/services/notify_service.rb:44:in `blocked?'
app/services/notify_service.rb:9:in `call'
app/services/process_interaction_service.rb:123:in `favourite!'
app/services/process_interaction_service.rb:41:in `call'
app/workers/salmon_worker.rb:9:in `perform'
@Gargron

This comment has been minimized.

Copy link
Member

commented Apr 16, 2017

The weird thing is... There should never be a local account without a user... So weird.. But this is definitely a fix.

@ineffyble
Copy link
Collaborator

left a comment

Looks good.

@Gargron Gargron merged commit 19f63ff into tootsuite:master Apr 16, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate no new or fixed issues
Details

Nyoho pushed a commit to Nyoho/mastodon that referenced this pull request Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.