New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2195 - Set locale to error pages #2255

Merged
merged 2 commits into from Apr 21, 2017

Conversation

Projects
None yet
3 participants
@takp
Contributor

takp commented Apr 21, 2017

Fix #2195

(e.g.) errors/404 page with correct locale
image

@mjankowski

This comment has been minimized.

Collaborator

mjankowski commented Apr 21, 2017

Good changes, thanks!

These methods are basically all the same -- What do you think about wrapping them up into something like:

def respond_with_error(code)
 # ...
render "errors/#{code}", layout: :error, status: code
end

and then have each of the other methods call that one with the appropriate code?

@Gargron Gargron merged commit 5e33ad2 into tootsuite:master Apr 21, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate no new or fixed issues
Details

@takp takp deleted the takp:set-locale-for-error-pages branch Apr 21, 2017

seefood added a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017

Fix tootsuite#2195 - Set locale to error pages (tootsuite#2255)
* Fix tootsuite#2195 - Set locale to error pages

* Fix tootsuite#2195 - Cut duplicate process into one method

y0t4 added a commit to y0t4/mastodon that referenced this pull request Apr 29, 2017

Fix tootsuite#2195 - Set locale to error pages (tootsuite#2255)
* Fix tootsuite#2195 - Set locale to error pages

* Fix tootsuite#2195 - Cut duplicate process into one method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment