use Twitter::Extractor for creating links

[masarakki]

I found a problem in creating link tag.

Conditions:

• Status contains mentions
• Status contains url with =@username (in mentions)

For example,

@masarakki

http://example.com/?x=@masarakki

In this case,
At first, encode_and_link_urls convert url to <a href="http://example.com/?x=@masarakki" rel="nofollow ...">http://example.com/?x=@masarakki</a>.
Then, because of =@username matches to Account::ACCOUNT_RE, @masarakki will be convert to link by link_mentions.
At last, it will be <a href="http://example.com/?x=<a href="/...">@masarakki</a> rel="nofollow ...">

Sample: https://friends.nico/@masarakki/2717988

[Gargron]

cc @abcang

[masarakki]

I think simple replacement is dangerous, I have an idea to use placeholder-like replacement.

for example,

html, links = encode_and_link_urls("@masakki Hello, world!,  http://example.com/?x=@masarakki", [])
#=> html: "@masarakki Hello, world!, \1", links: ['<a href="http://example.com/?x=@masarakki">http://example.com/?x=@masarakki</a>']

html, links = link_mentions(html, link)
#=> html: "\2 Hello, world!, \1", links: ['<a href="http://example.com/?x=@masarakki>...</a>' '<a href="/users/1">@masarakki</a>']

html = build(html, links)
#=> '<a href="/usrs/1>@masarakki</a> Hello, world! <a href="http://example.com...'
....

of cource, \1 is not suitable because user can inject this string.

[abcang]

I think that it is safe to replace it after extracting the target like twitter-text.

[Gargron]

Is this meant to be called rewrite?

[masarakki]

oh sorry