New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(character-count): Do not embed dynamic value in sentence #2685

Merged
merged 1 commit into from May 13, 2017

Conversation

Projects
None yet
2 participants
@stephenburgess8
Contributor

stephenburgess8 commented May 1, 2017

Restructure label to not embed dynamic value in sentence. This allows for grammatical correctness whether the number is one or not one.

#2678

screen shot 2017-05-01 at 10 03 37 am

@stephenburgess8

This comment has been minimized.

Show comment
Hide comment
@stephenburgess8

stephenburgess8 May 1, 2017

Contributor

Feel free to close if you would prefer this not be changed.

Contributor

stephenburgess8 commented May 1, 2017

Feel free to close if you would prefer this not be changed.

feat(count): Just yml count syntax to provide different rule for 1
Update all translation forms that use this "counter" element.
@stephenburgess8

This comment has been minimized.

Show comment
Hide comment
@stephenburgess8

stephenburgess8 May 13, 2017

Contributor

Thanks for your note on this. https://webtranslateit.com/docs/file_formats/yaml/

I've tested this view in all the languages that I've changed here. I've noticed two things which looks like either cruft or something is wrong:

For Brazilian Portuguese, the profile edit view isn't being translated. (this is happening before the changes I made)
The Turkish devise.tr.yml file uses these translations, but these aren't translated in that part of the code AFAICT. That should possibly be deleted from the Turkish translation file. Should I open an issue for either of those? I don't use them, I just noticed it when testing.

Contributor

stephenburgess8 commented May 13, 2017

Thanks for your note on this. https://webtranslateit.com/docs/file_formats/yaml/

I've tested this view in all the languages that I've changed here. I've noticed two things which looks like either cruft or something is wrong:

For Brazilian Portuguese, the profile edit view isn't being translated. (this is happening before the changes I made)
The Turkish devise.tr.yml file uses these translations, but these aren't translated in that part of the code AFAICT. That should possibly be deleted from the Turkish translation file. Should I open an issue for either of those? I don't use them, I just noticed it when testing.

@Gargron Gargron merged commit 4bd0488 into tootsuite:master May 13, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akihikodaki akihikodaki referenced this pull request Jun 29, 2017

Closed

Typo on Edit Profile #2678

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment