Fix Scheduler::SubscriptionsScheduler #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
commented
May 6, 2017
| include Sidekiq::Worker | ||
|
|
||
| def perform(status_id) | ||
| FanOutOnWriteService.new.call(Status.find(status_id)) | ||
| rescue ActiveRecord::RecordNotFound | ||
| info("Couldn't find the status") | ||
| true |
There was a problem hiding this comment.
Just as a comment for future reference: we don't really care if this status is not found. For example, user deletes status right after sending it out. It might already be gone before this job gets executed. That's okay.
mjankowski
approved these changes
May 6, 2017
Gargron
added a commit
that referenced
this pull request
May 6, 2017
* Fix Scheduler::SubscriptionsScheduler, add worker test for it * Change production log level of Sidekiq to "warn" instead of "info"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a missing
.eachhas slipped by. Added a test for it. Also Sidekiq has its own logger, use that instead of the Rails one. And change Sidekiq production log level to warn instead of info for less noise.