Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use joins for account properties #3167

Merged
merged 1 commit into from May 20, 2017

Conversation

@akihikodaki
Copy link
Collaborator

akihikodaki commented May 20, 2017

No description provided.

@akihikodaki akihikodaki force-pushed the kagucho:join branch to baacce3 May 20, 2017
@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented May 20, 2017

Is this a performance improvement?

@akihikodaki

This comment has been minimized.

Copy link
Collaborator Author

akihikodaki commented May 20, 2017

Yes. And it also reduces code complexity (removal of .map { |a| [a.id, a] }.to_h, etc)

@Gargron Gargron merged commit f554807 into tootsuite:master May 20, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate no new or fixed issues
Details
@ykzts ykzts mentioned this pull request May 20, 2017
unarist added a commit to unarist/mastodon that referenced this pull request May 23, 2017
Link headers in following/followers API should include follow_id as max_id/since_id.

However, these API use current_user's account_id instead of follow_id from tootsuite#3167.
This causes irrelevant result on loading more users.
Gargron added a commit that referenced this pull request May 23, 2017
Link headers in following/followers API should include follow_id as max_id/since_id.

However, these API use current_user's account_id instead of follow_id from #3167.
This causes irrelevant result on loading more users.
YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017
…#3268)

Link headers in following/followers API should include follow_id as max_id/since_id.

However, these API use current_user's account_id instead of follow_id from tootsuite#3167.
This causes irrelevant result on loading more users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.