Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video having black border on top due to regression from #2608 #3392

Merged
merged 1 commit into from May 28, 2017

Conversation

@Gargron
Copy link
Member

commented May 28, 2017

The combination of object-fit, relative position 50% from top and translating it back upwards 50% is what allows us to crop the video properly, so it needs to be +50%-50%

The combination of object-fit, relative position 50% from top and translating it
back upwards 50% is what allows us to crop the video properly, so it needs to
be +50%-50%
@ykzts
ykzts approved these changes May 28, 2017
Copy link
Collaborator

left a comment

Tested in desktop Chrome, Edge, Firefox, and Safari, and I can reproduce the problem in all four as well as confirm that this PR fixes it.

Incidentally Edge doesn't support object-fit yet but it gracefully degrades (by having black bars on the left and right) and this PR is still an improvement because there's no more black bar on top.

@nolanlawson nolanlawson added the bug label May 28, 2017
@Gargron Gargron merged commit 3fa8512 into master May 28, 2017
3 checks passed
3 checks passed
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Gargron Gargron deleted the fix-video-cropping branch May 28, 2017
gol-cha added a commit to gol-cha/mastodon that referenced this pull request May 29, 2017
…#2608 (tootsuite#3392)

The combination of object-fit, relative position 50% from top and translating it
back upwards 50% is what allows us to crop the video properly, so it needs to
be +50%-50%
YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017
…#2608 (tootsuite#3392)

The combination of object-fit, relative position 50% from top and translating it
back upwards 50% is what allows us to crop the video properly, so it needs to
be +50%-50%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.