Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting-for-account-deletable #3852

Merged
merged 1 commit into from Jun 19, 2017

Conversation

@masarakki
Copy link
Contributor

@masarakki masarakki commented Jun 19, 2017

No description provided.

@Gargron
Copy link
Member

@Gargron Gargron commented Jun 19, 2017

I am not against this but I'd like to learn more about the context where this came up

@masarakki masarakki force-pushed the masarakki:setting-for-account-deletable branch Jun 19, 2017
app/controllers/settings/deletes_controller.rb Outdated
@@ -21,6 +22,10 @@ def destroy

private

def check_enabled_deletion
redirect_to root_path if !Setting.open_deletion

This comment has been minimized.

@ykzts

ykzts Jun 19, 2017
Member

unless Setting.open_deletion

@masarakki masarakki force-pushed the masarakki:setting-for-account-deletable branch Jun 19, 2017
@masarakki
Copy link
Contributor Author

@masarakki masarakki commented Jun 19, 2017

Because if account deletion is enabled, it's probable that someone say "DELETE ACCOUNT PLEASE" to others and it's make world violent.

@EzoeRyou
Copy link

@EzoeRyou EzoeRyou commented Jun 19, 2017

Context I've heard from masarakki:

If the user can easily delete his account, there will be a lot of online harassment which goes something like:

"Yo! You worthless sucker! Delete your account!"

Many people can't stand this kind of harassment and just follow the demand and delete his account. Then, they later want to revive the account, but it's technically impossible in current implementation.

If account deletion feature doesn't exist, this kind of harassment and subsequent unfortunate account deletion doesn't happen.

In an ideal world, harassment should be punished and prevented. But we can't censor all the toots before it is posted. So harassment happens and and there always some victims who's mind is weak enough to follow the harasser's demand.

So, some instances(like friends.nico) prefer the old way. If you want to delete your account, contact the admin and asked for it.

@EzoeRyou
Copy link

@EzoeRyou EzoeRyou commented Jun 19, 2017

masarakki also said if we have an account suspend feature which hide the account and all toots(rather and complete deletion), harassment victims who follow the demand can later revive the account.

app/views/auth/registrations/edit.html.haml Outdated
@@ -14,5 +14,6 @@

%hr/

This comment has been minimized.

@Gargron

Gargron Jun 19, 2017
Member

Include this hr in the if

@masarakki masarakki force-pushed the masarakki:setting-for-account-deletable branch Jun 19, 2017
@masarakki
Copy link
Contributor Author

@masarakki masarakki commented Jun 19, 2017

updated.

@masarakki masarakki force-pushed the masarakki:setting-for-account-deletable branch Jun 19, 2017
@masarakki masarakki force-pushed the masarakki:setting-for-account-deletable branch to a3a3993 Jun 19, 2017
@Gargron Gargron merged commit ff142eb into tootsuite:master Jun 19, 2017
2 checks passed
2 checks passed
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@masarakki masarakki deleted the masarakki:setting-for-account-deletable branch Jun 19, 2017
@mistermantas
Copy link
Contributor

@mistermantas mistermantas commented Jun 22, 2017

No, no, no, this is stupid, because:

  1. this makes switching instances harder since you can't just delete your old account
  2. this goes against the want for privacy—cleaning everything off your account can be useful in many circumstances
  3. and if someone deleted their account because of harassment, they can recreate it.
  4. plus, this is just another thing to look out for when searching instances...

(If you're stupid enough to ignore the warnings though, and do delete your account unwillingly, that's your own problem, I think.) Maybe adding a 7-14 day restore period is a better idea?

@Gargron
Copy link
Member

@Gargron Gargron commented Jun 22, 2017

@mistermantas Because currently account deletions are instant and bothersome to restore manually, I have accepted this. Also there are cases where you genuinely don't want to enable account deletions, for example if you are sourcing the accounts from a different software, e. g. LDAP or some other tight integration.

koteitan added a commit to koteitan/mastodon that referenced this pull request Jun 25, 2017
YaQ00 pushed a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants