New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object-fit polyfill for Edge #4182

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@unarist
Collaborator

unarist commented Jul 13, 2017

Edge 16 supports object-fit, but it's still in preview version.

Also there is another polyfill for 'srcset' attribute, but I omited that since it's not huge issue like this I think.

cc @nolanlawson

@unarist unarist added the ui label Jul 13, 2017

@Gargron

This comment has been minimized.

Member

Gargron commented Jul 13, 2017

Please fix conflict!

@unarist unarist force-pushed the unarist:object-fit-edge branch from eda47e7 to be036f2 Jul 13, 2017

@unarist

This comment has been minimized.

Collaborator

unarist commented Jul 13, 2017

done.

@Gargron Gargron merged commit eeb5923 into tootsuite:master Jul 13, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@unarist unarist deleted the unarist:object-fit-edge branch Jul 14, 2017

@nolanlawson

This comment has been minimized.

Collaborator

nolanlawson commented Jul 18, 2017

Edge 16 will ship in the Fall Creators Update (in a few months), and as-is I didn't find the lack of object-fit to be a big deal when using Edge (the images were still visible, just a bit smaller). Just FWIW. 😃

abcang added a commit to pixiv/mastodon that referenced this pull request Jul 26, 2017

YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment