Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unfollow modal (optional) #4246

Merged
merged 3 commits into from Jul 18, 2017

Conversation

@ykzts
Copy link
Collaborator

commented Jul 18, 2017

I don't want to unfollow friends by mistake.

screenshot

@ykzts ykzts added the ui label Jul 18, 2017
Copy link
Member

left a comment

👍

@@ -42,6 +42,7 @@ en:
setting_default_sensitive: Always mark media as sensitive
setting_delete_modal: Show confirmation dialog before deleting a toot
setting_system_font_ui: Use system's default font
setting_unfollow_modal: Show confirmation dialog before unfollow an account

This comment has been minimized.

Copy link
@Gargron

Gargron Jul 18, 2017

Member

"Before unfollowing someone"

This comment has been minimized.

Copy link
@ykzts

ykzts Jul 18, 2017

Author Collaborator

thx! 9687d82

@@ -22,6 +22,7 @@ export default class Account extends ImmutablePureComponent {
static propTypes = {
account: ImmutablePropTypes.map.isRequired,
me: PropTypes.number.isRequired,
unfollowModal: PropTypes.bool,

This comment has been minimized.

Copy link
@Gargron

Gargron Jul 18, 2017

Member

I think this component doesn't need to be aware of this.

@@ -11,6 +11,7 @@ export default class Header extends ImmutablePureComponent {
static propTypes = {
account: ImmutablePropTypes.map,
me: PropTypes.number.isRequired,
unfollowModal: PropTypes.bool,

This comment has been minimized.

Copy link
@Gargron

Gargron Jul 18, 2017

Member

I think this component doesn't need to be aware of this.

This comment has been minimized.

Copy link
@ykzts

ykzts Jul 18, 2017

Author Collaborator

thx! 8724533

@Gargron Gargron merged commit 3267e4a into tootsuite:master Jul 18, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ykzts ykzts deleted the ykzts:unfollow-modal branch Jul 18, 2017
lindwurm added a commit to lindwurm/mastodon that referenced this pull request Jul 18, 2017
Signed-off-by: lindwurm <lindwurm.q@gmail.com>
Gargron added a commit that referenced this pull request Jul 18, 2017
Signed-off-by: lindwurm <lindwurm.q@gmail.com>
YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017
* Add unfollow modal

* unfollowing someone

* remove unnecessary prop
YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017
Signed-off-by: lindwurm <lindwurm.q@gmail.com>
@Gargron Gargron referenced this pull request Apr 8, 2018
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.