Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when a user tries to search nonexistent remote user #4400

Merged
merged 1 commit into from Jul 27, 2017

Conversation

@nullkal
Copy link
Collaborator

commented Jul 27, 2017

Before merging #4275, when a user tries to search an nonexistent remote user, Goldfinger.finger raises Goldfinger::Error and renders the JSON { error: 'Remote account could not be resolved' } with 422 HTTP status code.

However, after #4275, Goldfinger::Error is rescued in ResolveRemoteAccountService#call and it returns nil instead of propagating the exception. In such a situation, AccountSearchService#search_service_results returns [nil] and it causes an error.

@ykzts ykzts added the bug label Jul 27, 2017
@Gargron Gargron merged commit 6654c30 into tootsuite:master Jul 27, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nullkal nullkal deleted the fix_error_search_nonexistent_remote_account branch Jul 28, 2017
hcmiya added a commit to hcmiya/v6don that referenced this pull request Jul 29, 2017
YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.