Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button overflow on confirmation modal for mobile #4465

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
2 participants
@unarist
Copy link
Collaborator

commented Jul 31, 2017

image
image

Note that still button (and text) may overflow on some language or some device width (e.g. iPhone 5s). Reducing horizontal padding from 16px to 8px would helps supporting more (not all) combination, but modifying it requires JS change or !important.

However, this change seems reasonable anyway.


For the reference, we have below translations for "Hide entire domain" now. I think supporting all sentence in current layout is hard, so changing layout on mobile or change translation would be solution.

Negeer alles van deze server
Masquer le domaine entier
Ukryj wszysyko z domeny
Блокировать весь домен
Amagar tot lo domeni
Amagar tot el domini
Skjul alt fra domenet
Sakrij cijelu domenu
ドメイン全体を非表示
Сховати весь домен
도메인 전체를 숨김
Hide entire domain
پنهان‌سازی کل دامین
הסתר קהילה שלמה
隱藏整個網域

@Gargron Gargron merged commit 82b4cf4 into tootsuite:master Jul 31, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

pfigel added a commit to pfigel/mastodon that referenced this pull request Aug 3, 2017

Merge tag 'v1.5.0' into stable
* tag 'v1.5.0': (333 commits)
  Bump to 1.5.0
  Update Dutch (nl) strings (tootsuite#4480)
  Show SMTP_TLS in config sample (tootsuite#4477)
  fix(web_push_notifications): Send message with welcome notifications (tootsuite#4471)
  Change logo URL for Heroku and Scalingo (tootsuite#4476)
  Add libidn11 to Aptfile (tootsuite#4475)
  Re-add outline (tootsuite#4474)
  do not emojify tm, (R) and (C) (tootsuite#4472)
  i18n: update Persian translation (tootsuite#4470)
  Load extra polyfills when isIntersecting is undefined (tootsuite#4469)
  Bump to 1.5.0rc3
  Simplify web UI character counter logic (tootsuite#4463)
  Fix button overflow on confirmation modal for mobile (tootsuite#4465)
  Change RuboCop rules to loose (tootsuite#4464)
  i18n: Update Polish translation (tootsuite#4467)
  Disable sensitive button when with content warnings (tootsuite#4460)
  Fix length validator counting things that look like URIs like URLs (tootsuite#4462)
  Make salutation of email localizable (tootsuite#4454)
  Improve accessibility (part 7) (tootsuite#4457)
  Change to sensitive when adding content warning from web UI (tootsuite#4456)
  ...

YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017

@unarist unarist deleted the unarist:fix/wide-confirmation branch Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.