New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logo URL for Heroku and Scalingo #4476

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@ykzts
Collaborator

ykzts commented Aug 1, 2017

馃帀 WELCOME BACK 馃帀

@@ -2,7 +2,7 @@
"name": "Mastodon",
"description": "A GNU Social-compatible microblogging server",
"repository": "https://github.com/tootsuite/mastodon",
"logo": "https://github.com/tootsuite/mastodon/raw/master/app/javascript/images/logo.svg",

This comment has been minimized.

@ykzts

ykzts Aug 1, 2017

Collaborator

The raw format of GitHub returns Content-type: text/plain. SVG will not be rendered unless Content-type is image/svg+xml when imported with img element.

I thought it would be better to use an avatar image with a permanently URL.

@Gargron

Gargron approved these changes Aug 1, 2017

@Gargron Gargron merged commit e05606c into tootsuite:master Aug 1, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ykzts ykzts deleted the ykzts:mastodon-logo branch Aug 1, 2017

patf added a commit to patf/mastodon that referenced this pull request Aug 3, 2017

Merge tag 'v1.5.0' into stable
* tag 'v1.5.0': (333 commits)
  Bump to 1.5.0
  Update Dutch (nl) strings (tootsuite#4480)
  Show SMTP_TLS in config sample (tootsuite#4477)
  fix(web_push_notifications): Send message with welcome notifications (tootsuite#4471)
  Change logo URL for Heroku and Scalingo (tootsuite#4476)
  Add libidn11 to Aptfile (tootsuite#4475)
  Re-add outline (tootsuite#4474)
  do not emojify tm, (R) and (C) (tootsuite#4472)
  i18n: update Persian translation (tootsuite#4470)
  Load extra polyfills when isIntersecting is undefined (tootsuite#4469)
  Bump to 1.5.0rc3
  Simplify web UI character counter logic (tootsuite#4463)
  Fix button overflow on confirmation modal for mobile (tootsuite#4465)
  Change RuboCop rules to loose (tootsuite#4464)
  i18n: Update Polish translation (tootsuite#4467)
  Disable sensitive button when with content warnings (tootsuite#4460)
  Fix length validator counting things that look like URIs like URLs (tootsuite#4462)
  Make salutation of email localizable (tootsuite#4454)
  Improve accessibility (part 7) (tootsuite#4457)
  Change to sensitive when adding content warning from web UI (tootsuite#4456)
  ...

YaQ00 added a commit to YaQ00/mastodon that referenced this pull request Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment