New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct messages column #4514

Merged
merged 8 commits into from Apr 18, 2018

Conversation

Projects
None yet
8 participants
@KScl
Contributor

KScl commented Aug 4, 2017

Adds a column that shows all direct messages you've ever sent or received. Streaming has been tested and appears to be working fine on the servers I have it running on.

Column screenshot

Currently, the column link is only on Getting Started because I thought the tabs bar was getting cramped enough as it is, but that's easy enough to change.

@nevillepark

This comment has been minimized.

Show comment
Hide comment
@nevillepark

nevillepark Sep 19, 2017

Contributor

Can we please have this?

Now that there are pinned tabs there's little reason NOT to. The current method of putting DMs in your TL is going to be very confusing for users migrating from literally any other social networking service where private messages are separate from public ones.

Contributor

nevillepark commented Sep 19, 2017

Can we please have this?

Now that there are pinned tabs there's little reason NOT to. The current method of putting DMs in your TL is going to be very confusing for users migrating from literally any other social networking service where private messages are separate from public ones.

@ThibG

While I'm not too knowledgeable in this part of the code, apart from the needed rebase and the possible refactoring I hinted at, looks good to me!

KScl added some commits Oct 16, 2017

Added a timeline for Direct statuses
* Lists all Direct statuses you've sent and received
* Displayed in Getting Started
* Streaming server support for direct TL
@ThibG

Apart from the Getting Started changes I'm not too sure about, looks good to me! Going to try it on my instance right now.

if (!multiColumn || !columns.find(item => item.get('id') === 'DIRECT')) {
navItems.push(<ColumnLink key='4' icon='envelope' text={intl.formatMessage(messages.direct)} to='/timelines/direct' />);
}

This comment has been minimized.

@ThibG

ThibG Oct 23, 2017

Collaborator

Why is it not grouped with the tests for other columns?

@ThibG

ThibG Oct 23, 2017

Collaborator

Why is it not grouped with the tests for other columns?

This comment has been minimized.

@KScl

KScl Oct 23, 2017

Contributor

Because it's doing the exact opposite test; since it doesn't show in the navigation bar in single column mode (space concerns, as I mentioned already), it needs to always show up there.

@KScl

KScl Oct 23, 2017

Contributor

Because it's doing the exact opposite test; since it doesn't show in the navigation bar in single column mode (space concerns, as I mentioned already), it needs to always show up there.

This comment has been minimized.

@ThibG

ThibG Oct 23, 2017

Collaborator

Ok, makes sense!

@ThibG

ThibG Oct 23, 2017

Collaborator

Ok, makes sense!

@ThibG

ThibG approved these changes Oct 23, 2017

beatrix-bitrot added a commit to glitch-soc/mastodon that referenced this pull request Oct 25, 2017

@ThibG

This comment has been minimized.

Show comment
Hide comment
@ThibG

ThibG Nov 15, 2017

Collaborator

Hm, attempted to rebase on master from github's interface, but I'm not completely sure what it did, since it still shows conflicts.

Collaborator

ThibG commented Nov 15, 2017

Hm, attempted to rebase on master from github's interface, but I'm not completely sure what it did, since it still shows conflicts.

@ThibG ThibG requested a review from Gargron Nov 15, 2017

@@ -40,6 +40,7 @@ def call(statuses)
# Cannot be batched
statuses.each do |status|
unpush_from_public_timelines(status)
unpush_from_direct_timelines(status) if status.direct_visibility?

This comment has been minimized.

@ykzts

ykzts Nov 16, 2017

Collaborator

This comment has been minimized.

@KScl

KScl Nov 16, 2017

Contributor

And this means... what, exactly?

@KScl

KScl Nov 16, 2017

Contributor

And this means... what, exactly?

This comment has been minimized.

@ykzts

ykzts Nov 16, 2017

Collaborator

Code Climate says the call method is too big. It is a good idea to split the call method into several private methods.

@ykzts

ykzts Nov 16, 2017

Collaborator

Code Climate says the call method is too big. It is a good idea to split the call method into several private methods.

This comment has been minimized.

@ThibG

ThibG Nov 16, 2017

Collaborator

While this indeed should probably be refactored, it's not completely obvious how, and I don't think this PR makes this particular function any more difficult to understand. So, I would personally say this is out of scope of this Pull Request.

@ThibG

ThibG Nov 16, 2017

Collaborator

While this indeed should probably be refactored, it's not completely obvious how, and I don't think this PR makes this particular function any more difficult to understand. So, I would personally say this is out of scope of this Pull Request.

@ThibG

This comment has been minimized.

Show comment
Hide comment
@ThibG

ThibG Dec 2, 2017

Collaborator

Merged master, it's running without issues on my instance.

Collaborator

ThibG commented Dec 2, 2017

Merged master, it's running without issues on my instance.

@ThibG ThibG referenced this pull request Dec 5, 2017

Merged

Add list of lists component to web UI #5811

4 of 4 tasks complete
@ThibG

This comment has been minimized.

Show comment
Hide comment
@ThibG

ThibG Jan 10, 2018

Collaborator

Merged master and successfully tested it on my instance.

@STJrInuyasha can we remove the work-in-progress label?

@Gargron if that PR doesn't satisfy you, could we know why?

Collaborator

ThibG commented Jan 10, 2018

Merged master and successfully tested it on my instance.

@STJrInuyasha can we remove the work-in-progress label?

@Gargron if that PR doesn't satisfy you, could we know why?

@rummik

This comment has been minimized.

Show comment
Hide comment
@rummik

rummik Feb 24, 2018

Is this ready at this point? I don't typically write Ruby, but if there are still changes needed I'd be happy to help where I can to get it merged

rummik commented Feb 24, 2018

Is this ready at this point? I don't typically write Ruby, but if there are still changes needed I'd be happy to help where I can to get it merged

@rummik rummik referenced this pull request Feb 25, 2018

Closed

List direct toots, you've sent. #3801

1 of 2 tasks complete

@ThisIsMissEm ThisIsMissEm referenced this pull request Mar 29, 2018

Open

Better DM system #3819

1 of 1 task complete
@wxcafe

This comment has been minimized.

Show comment
Hide comment
@wxcafe

wxcafe Mar 29, 2018

Contributor

Up on this @Gargron

Contributor

wxcafe commented Mar 29, 2018

Up on this @Gargron

@ThibG

This comment has been minimized.

Show comment
Hide comment
@ThibG

ThibG Mar 30, 2018

Collaborator

#3819 (comment) should we close it, then?

Collaborator

ThibG commented Mar 30, 2018

#3819 (comment) should we close it, then?

Addressed?

@Gargron Gargron removed the request for review from unarist Apr 17, 2018

@ykzts

This comment has been minimized.

Show comment
Hide comment
@ykzts

ykzts Apr 18, 2018

Collaborator

I resolved conflicts.

Collaborator

ykzts commented Apr 18, 2018

I resolved conflicts.

@ykzts

ykzts approved these changes Apr 18, 2018

@Gargron Gargron merged commit 156b916 into tootsuite:master Apr 18, 2018

2 checks passed

codeclimate 1 fixed issue
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

SerCom-KC added a commit to SerCom-KC/mastodon that referenced this pull request May 21, 2018

Gargron added a commit that referenced this pull request May 21, 2018

i18n: Update Simplified Chinese translations (#7565)
* i18n: (zh-CN) #7532

* i18n: (zh-CN) #6984

* i18n: (zh-CN) #7391, #7507

* i18n: (zh-CN) #6998

* i18n: (zh-CN) #7074

* i18n: (zh-CN) #7000, #7032, #7131 (#7032, #7040)

* i18n: (zh-CN) #7130, #7188

* i18n: (zh-CN) #6486

* i18n: (zh-CN) #6292

* i18n: (zh-CN) #7347

* i18n: (zh-CN) #6661

* i18n: (zh-CN) #6425

* i18n: (zh-CN) #6597

* i18n: (zh-CN) #6695

* i18n: (zh-CN) #6325

* i18n: (zh-CN) #6460, #7375

* i18n: (zh-CN) #6872

* i18n: (zh-CN) #6818

* i18n: (zh-CN) #7452

* i18n: (zh-CN) #7176

* i18n: (zh-CN) #6460

* i18n: (zh-CN) #7213

* i18n: (zh-CN) #7376

* i18n: (zh-CN) #6556

* i18n: (zh-CN) #6645

* i18n: (zh-CN) #6448

* i18n: (zh-CN) #5303

* i18n: (zh-CN) #7445

* i18n: (zh-CN) Normalization and improvements

* i18n: (zh-CN) #7391

* i18n: (zh-CN) #6627

* i18n: (zh-CN) #6956, #7546

* i18n: (zh-CN) #6636

* i18n: (zh-CN) #6610, #6875

* i18n: (zh-CN) #6887

* i18n: (zh-CN) #4514

* i18n: (zh-CN) #6628

* i18n: (zh-CN) #6771

* i18n: (zh-CN) #6772

* i18n: (zh-CN) #7178

* i18n: (zh-CN) #7521

* i18n: (zh-CN) #6570

* i18n: (zh-CN) #6593

* i18n: (zh-CN) #6423

* i18n: (zh-CN) #6157

* i18n: (zh-CN) #7089

* i18n: (zh-CN) #6733

* i18n: (zh-CN) #7072

* i18n: (zh-CN) #6520

* i18n: (zh-CN) Improvment

* i18n: (zh-CN) #6631

byronhulcher added a commit to byronhulcher/mastodon that referenced this pull request Aug 18, 2018

i18n: Update Simplified Chinese translations (tootsuite#7565)
* i18n: (zh-CN) tootsuite#7532

* i18n: (zh-CN) tootsuite#6984

* i18n: (zh-CN) tootsuite#7391, tootsuite#7507

* i18n: (zh-CN) tootsuite#6998

* i18n: (zh-CN) tootsuite#7074

* i18n: (zh-CN) tootsuite#7000, tootsuite#7032, tootsuite#7131 (tootsuite#7032, tootsuite#7040)

* i18n: (zh-CN) tootsuite#7130, tootsuite#7188

* i18n: (zh-CN) tootsuite#6486

* i18n: (zh-CN) tootsuite#6292

* i18n: (zh-CN) tootsuite#7347

* i18n: (zh-CN) tootsuite#6661

* i18n: (zh-CN) tootsuite#6425

* i18n: (zh-CN) tootsuite#6597

* i18n: (zh-CN) tootsuite#6695

* i18n: (zh-CN) tootsuite#6325

* i18n: (zh-CN) tootsuite#6460, tootsuite#7375

* i18n: (zh-CN) tootsuite#6872

* i18n: (zh-CN) tootsuite#6818

* i18n: (zh-CN) tootsuite#7452

* i18n: (zh-CN) tootsuite#7176

* i18n: (zh-CN) tootsuite#6460

* i18n: (zh-CN) tootsuite#7213

* i18n: (zh-CN) tootsuite#7376

* i18n: (zh-CN) tootsuite#6556

* i18n: (zh-CN) tootsuite#6645

* i18n: (zh-CN) tootsuite#6448

* i18n: (zh-CN) tootsuite#5303

* i18n: (zh-CN) tootsuite#7445

* i18n: (zh-CN) Normalization and improvements

* i18n: (zh-CN) tootsuite#7391

* i18n: (zh-CN) tootsuite#6627

* i18n: (zh-CN) tootsuite#6956, tootsuite#7546

* i18n: (zh-CN) tootsuite#6636

* i18n: (zh-CN) tootsuite#6610, tootsuite#6875

* i18n: (zh-CN) tootsuite#6887

* i18n: (zh-CN) tootsuite#4514

* i18n: (zh-CN) tootsuite#6628

* i18n: (zh-CN) tootsuite#6771

* i18n: (zh-CN) tootsuite#6772

* i18n: (zh-CN) tootsuite#7178

* i18n: (zh-CN) tootsuite#7521

* i18n: (zh-CN) tootsuite#6570

* i18n: (zh-CN) tootsuite#6593

* i18n: (zh-CN) tootsuite#6423

* i18n: (zh-CN) tootsuite#6157

* i18n: (zh-CN) tootsuite#7089

* i18n: (zh-CN) tootsuite#6733

* i18n: (zh-CN) tootsuite#7072

* i18n: (zh-CN) tootsuite#6520

* i18n: (zh-CN) Improvment

* i18n: (zh-CN) tootsuite#6631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment