Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread toot notification mails by conversation #5061

Merged
merged 2 commits into from Sep 24, 2017

Conversation

@ThibG
Copy link
Collaborator

commented Sep 23, 2017

This change threads e-mail notifications by conversation when possible.

I initially wanted to use the (single-quoted) Mastodon-generated conversation identifiers as the local-part of the message identifier, but I decided to just take the index of the conversation in the database: indeed, we have no control over external conversations URI and thus I don't know how we could derive unique and valid e-mail addresses from those.

Copy link
Member

left a comment

Seems cool

@Gargron Gargron merged commit c267acf into tootsuite:master Sep 24, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ThibG ThibG deleted the ThibG:mailer-threads branch Oct 4, 2017
rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
* Thread toot notification mails by conversation

* Make codeclimate happy and avoid potential mis-threading
takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017
* Thread toot notification mails by conversation

* Make codeclimate happy and avoid potential mis-threading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.