Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web UI warnings about OStatus privacy #5102

Merged
merged 2 commits into from Sep 27, 2017

Conversation

@Gargron
Copy link
Member

commented Sep 25, 2017

  • OStatus no longer used for private/direct posts

const WarningWrapper = ({ needsLeakWarning, needsLockWarning, mentionedDomains }) => {
if (needsLockWarning) {
return <Warning message={<FormattedMessage id='compose_form.lock_disclaimer' defaultMessage='Your account is not {locked}. Anyone can follow you to view your follower-only posts.' values={{ locked: <a href='/settings/profile'><FormattedMessage id='compose_form.lock_disclaimer.lock' defaultMessage='locked' /></a> }} />} />;

This comment has been minimized.

Copy link
@nightpool

nightpool Sep 25, 2017

Collaborator

this warning should still stay right?

Your account is not {locked}. Anyone can follow you to view your follower-only posts

Nothing about how this works has changed.

This comment has been minimized.

Copy link
@Gargron

Gargron Sep 25, 2017

Author Member

Yeah but isn't it kinda obvious? Why do we have this warning?

This comment has been minimized.

Copy link
@akihikodaki

akihikodaki Sep 26, 2017

Collaborator

It is nice to have a first-time warning. The current warning should be left as is till then. There is no reason to change it now.

<Warning
message={<FormattedMessage
id='compose_form.privacy_disclaimer'
defaultMessage='Your private status will be delivered to mentioned users on {domains}. Do you trust {domainsCount, plural, one {that server} other {those servers}}? Post privacy only works on Mastodon instances. If {domains} {domainsCount, plural, one {is not a Mastodon instance} other {are not Mastodon instances}}, there will be no indication that your post is private, and it may be boosted or otherwise made visible to unintended recipients.'

This comment has been minimized.

Copy link
@nightpool

nightpool Sep 25, 2017

Collaborator

I think there should still maybe be some type of warning about trusting remote servers? Not sure.

Definitely feels like there should be some copy in the main UI about this even if i'm not sure what

This comment has been minimized.

Copy link
@Gargron

Gargron Sep 25, 2017

Author Member

We only put it in because of GNU social. While it's technically true, it's just as true when you're writing an e-mail or messaging someone on XMPP. The remote server has to be trusted. In fact, logging in to a website is trusting a remote server with your data. I don't think the difference with Mastodon is now such that a special warning is warranted.

@Gargron Gargron force-pushed the fix-remove-ostatus-warnings branch from 2be835e to 4029ea5 Sep 26, 2017
Copy link
Contributor

left a comment

in AP posts are addressed to recipients, therefore an implementation would have to be malicious rather than incompetent to violate privacy stuff

SO

I think I agree with garg's reasoning for now

@Gargron Gargron dismissed nightpool’s stale review Sep 27, 2017

Addressed

@Gargron Gargron merged commit e648ef0 into master Sep 27, 2017
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Gargron Gargron deleted the fix-remove-ostatus-warnings branch Sep 27, 2017
rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
* Remove web UI warnings about OStatus privacy

* yarn run manage:translations
takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017
* Remove web UI warnings about OStatus privacy

* yarn run manage:translations
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
* Remove web UI warnings about OStatus privacy

* yarn run manage:translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.