Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify alternative text for media attachments #5123

Merged
merged 3 commits into from Sep 28, 2017

Conversation

@Gargron
Copy link
Member

commented Sep 28, 2017

Fix #117

  • POST /api/v1/media accepts description straight away
  • PUT /api/v1/media/:id to update description (only for unattached ones)
  • Serialized as name of Document object in ActivityPub
  • Uploads form adjusted for better performance and description input

image
image

- POST /api/v1/media accepts `description` straight away
- PUT /api/v1/media/:id to update `description` (only for unattached ones)
- Serialized as `name` of Document object in ActivityPub
- Uploads form adjusted for better performance and description input
Gargron added 2 commits Sep 28, 2017
@@ -50,4 +49,12 @@
expect(media.file.meta["small"]["aspect"]).to eq 400.0/267
end
end

describe 'descriptions for remote attachments' do
it 'are cut off at 140 characters' do

This comment has been minimized.

Copy link
@beatrix-bitrot

beatrix-bitrot Sep 28, 2017

Contributor

are -> is

This comment has been minimized.

Copy link
@Gargron

Gargron Sep 28, 2017

Author Member

descriptions for remote attachments -> are cut off at 140 characters

This comment has been minimized.

Copy link
@beatrix-bitrot

beatrix-bitrot Sep 28, 2017

Contributor

yeah but 'it'...

Copy link
Contributor

left a comment

approved with caveat that some tweaks will likely be required before release

@Gargron Gargron merged commit 4ec1771 into master Sep 28, 2017
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Gargron Gargron deleted the feature-media-alt branch Sep 28, 2017
@pwoolcoc

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2017

I'm so so happy this finally got in! 🎆 🎉

I was just curious, is there a reason for the 140-character limit?

@jmfcodes

This comment has been minimized.

Copy link

commented Sep 28, 2017

Thank you for working on this!! This is really appreciated! And I'm sorry to be picky and never pleased, but is there any way we can bump up that 140-char limit? As a general rule, that's probably good for a real general description ("person holding a cat," "sleeping cat"), but for more detailed stuff, 500 char would be ideal and hopefully encourage people to use it... since many of us know the frustration of trying to cram a decent description of anything into 140 chars ;)

@Sylvhem

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2017

Thank you so much for you work on that! It was a really needed feature.

I think the 140 characters limit looks kinda weird thought. 140 seems like a random number to me. Do you think it's possible to bump it to 150?

@ZoeBijl

This comment has been minimized.

Copy link

commented Sep 29, 2017

The 140 char limit is really low. Twitter uses 420.

Gargron added a commit that referenced this pull request Oct 3, 2017
* yarn manage:translations

* Add Japanese translations for #5170

* Add Japanese translations for #5123

* Add Japanese translations for #5046

* Add Japanese translations for #5099

* Add Japanese translations for #5161

* "項目" -> "絵文字"
rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
…ite#5123)

* Fix tootsuite#117 - Add ability to specify alternative text for media attachments

- POST /api/v1/media accepts `description` straight away
- PUT /api/v1/media/:id to update `description` (only for unattached ones)
- Serialized as `name` of Document object in ActivityPub
- Uploads form adjusted for better performance and description input

* Add tests

* Change undo button blend mode to difference
rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
* yarn manage:translations

* Add Japanese translations for tootsuite#5170

* Add Japanese translations for tootsuite#5123

* Add Japanese translations for tootsuite#5046

* Add Japanese translations for tootsuite#5099

* Add Japanese translations for tootsuite#5161

* "項目" -> "絵文字"
takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017
…ite#5123)

* Fix tootsuite#117 - Add ability to specify alternative text for media attachments

- POST /api/v1/media accepts `description` straight away
- PUT /api/v1/media/:id to update `description` (only for unattached ones)
- Serialized as `name` of Document object in ActivityPub
- Uploads form adjusted for better performance and description input

* Add tests

* Change undo button blend mode to difference
takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017
* yarn manage:translations

* Add Japanese translations for tootsuite#5170

* Add Japanese translations for tootsuite#5123

* Add Japanese translations for tootsuite#5046

* Add Japanese translations for tootsuite#5099

* Add Japanese translations for tootsuite#5161

* "項目" -> "絵文字"
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
…ite#5123)

* Fix tootsuite#117 - Add ability to specify alternative text for media attachments

- POST /api/v1/media accepts `description` straight away
- PUT /api/v1/media/:id to update `description` (only for unattached ones)
- Serialized as `name` of Document object in ActivityPub
- Uploads form adjusted for better performance and description input

* Add tests

* Change undo button blend mode to difference
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
* yarn manage:translations

* Add Japanese translations for tootsuite#5170

* Add Japanese translations for tootsuite#5123

* Add Japanese translations for tootsuite#5046

* Add Japanese translations for tootsuite#5099

* Add Japanese translations for tootsuite#5161

* "項目" -> "絵文字"
@ykzts ykzts referenced this pull request Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.