Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve privacy dropdown, remove react-simple-dropdown dependency #5140

Merged
merged 3 commits into from Oct 1, 2017

Conversation

@Gargron
Copy link
Member

commented Sep 29, 2017

Demo: https://mastodon.social/@Gargron/19924525

  • react-simple-dropdown is no longer used by anything
  • put consistent animation on privacy dropdown like other dropdowns
  • put smooth appear animation on privacy warning
@Gargron Gargron added the ui label Sep 29, 2017
@beatrix-bitrot beatrix-bitrot requested a review from nolanlawson Sep 29, 2017
handleKeyDown = e => {
switch(e.key) {
case 'Enter':
this.handleClick();

This comment has been minimized.

Copy link
@nightpool

nightpool Sep 30, 2017

Collaborator

this calls handleClick but as far as I can tell, handleClick isn't in this scope?

@Gargron Gargron force-pushed the fix-privacy-dropdown branch from 462a3b3 to 0349d78 Sep 30, 2017
@Gargron Gargron force-pushed the fix-privacy-dropdown branch from 0349d78 to a368a96 Sep 30, 2017
@Gargron Gargron merged commit cdad797 into master Oct 1, 2017
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Gargron Gargron deleted the fix-privacy-dropdown branch Oct 1, 2017
rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
…otsuite#5140)

* Improve privacy dropdown, remove react-simple-dropdown dependency

* Animate privacy warning

* Fix react-router-scroll
takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017
…otsuite#5140)

* Improve privacy dropdown, remove react-simple-dropdown dependency

* Animate privacy warning

* Fix react-router-scroll
@iliana iliana referenced this pull request Oct 12, 2017
2 of 2 tasks complete
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
…otsuite#5140)

* Improve privacy dropdown, remove react-simple-dropdown dependency

* Animate privacy warning

* Fix react-router-scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.