New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable streaming on heroku #5158

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Kjwon15
Contributor

Kjwon15 commented Sep 30, 2017

I am using dokku(Heroku like personal PaaS) but I found mastodon is not running streaming server by default on heroku(#1119).

This PR will make mastodon is able to stream on heroku by default.

@Gargron Gargron requested a review from ineffyble Sep 30, 2017

@ykzts

This comment has been minimized.

Show comment
Hide comment
@ykzts

ykzts Sep 30, 2017

Collaborator

cc @zunda

Collaborator

ykzts commented Sep 30, 2017

cc @zunda

@zunda

This comment has been minimized.

Show comment
Hide comment
@zunda

zunda Sep 30, 2017

Collaborator

I'm not sure if running the streaming server along with Puma because they scale differently. Personally, I run the streaming server as a separate Heroku app that shares Postgres and Redis from the primary app.

Anyways, I wanted to know how much memory overhead Nginx and runit have. I tried but the Heroku Buildpack: NGINX doesn't seem to be compatible with the current stack:

$ git push heroku master
  :
remote: -----> nginx-buildpack app detected
remote: cp: cannot stat 'bin/nginx-heroku-16': No such file or directory
remote:  !     Push rejected, failed to compile nginx-buildpack app.
  :
Collaborator

zunda commented Sep 30, 2017

I'm not sure if running the streaming server along with Puma because they scale differently. Personally, I run the streaming server as a separate Heroku app that shares Postgres and Redis from the primary app.

Anyways, I wanted to know how much memory overhead Nginx and runit have. I tried but the Heroku Buildpack: NGINX doesn't seem to be compatible with the current stack:

$ git push heroku master
  :
remote: -----> nginx-buildpack app detected
remote: cp: cannot stat 'bin/nginx-heroku-16': No such file or directory
remote:  !     Push rejected, failed to compile nginx-buildpack app.
  :
@akihikodaki

This comment has been minimized.

Show comment
Hide comment
@akihikodaki

akihikodaki Nov 25, 2017

Collaborator

@Kjwon15 Sorry for late reply, but I wonder if having a sperate app as @zunda suggested works for you. If it is, we can update the documentation to solve the issue you encountered. Otherwise, we can continue reviewing your change.

Collaborator

akihikodaki commented Nov 25, 2017

@Kjwon15 Sorry for late reply, but I wonder if having a sperate app as @zunda suggested works for you. If it is, we can update the documentation to solve the issue you encountered. Otherwise, we can continue reviewing your change.

@Kjwon15 Kjwon15 closed this Jan 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment