Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle contain:strict on fullscreen #5159

Merged
merged 3 commits into from Oct 2, 2017

Conversation

@nolanlawson
Copy link
Collaborator

commented Sep 30, 2017

Previously we removed contain: strict because it interfered with video fullscreen (2bbf987). This PR adds it back in, but removes it whenever the video player goes fullscreen.

I also refactored the fullscreen-handling code and moved it to its own module. I removed the ms- prefixed calls because Edge uses the WebKit-prefixed ones, and we don't support IE.

Perf improvements

This is only a perf improvement in Chrome because it's the only browser to support CSS containment. But you can see the difference:

out

Browser support

I tested desktop Chrome, Edge, Firefox, and Safari. Everything works fine except for Safari, which is broken for video fullscreen both before and after this commit. So I'll open a separate issue for that.

nolanlawson added 2 commits Oct 1, 2017
@nolanlawson

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2017

Fixed some lint issues

@abcang
abcang approved these changes Oct 2, 2017
@Gargron Gargron merged commit c567c87 into tootsuite:master Oct 2, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017
* Toggle contain:strict on fullscreen

* Fix scss lint issue

* fix scss whitespace lint issue
takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017
* Toggle contain:strict on fullscreen

* Fix scss lint issue

* fix scss whitespace lint issue
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
* Toggle contain:strict on fullscreen

* Fix scss lint issue

* fix scss whitespace lint issue
@nightpool

This comment has been minimized.

Copy link
Collaborator

commented Nov 5, 2017

this seems to be broken again, or was never fixed for videos on detailed statuses (works fine in a timeline)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.