Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hotkeys for web UI #5164

Merged
merged 5 commits into from Oct 5, 2017

Conversation

Projects
None yet
6 participants
@Gargron
Copy link
Member

Gargron commented Oct 1, 2017

Demo: https://mastodon.social/@Gargron/20188468

Hotkeys:

  • r to reply
  • m to mention author
  • f to favourite
  • b to boost
  • enter to open status
  • p to open author's profile
  • up or k to move up in the list
  • down or j to move down in the list
  • 1-9 to focus a status in one of the columns
  • n to focus the compose textarea
  • alt+n to start a brand new toot
  • backspace to navigate back
  • s to focus search
  • esc to un-focus compose textarea/search
  • various "goto" combinations

@Gargron Gargron force-pushed the feature-hotkeys branch 2 times, most recently from 95bbf03 to 5a8db84 Oct 1, 2017

@nolanlawson
Copy link
Collaborator

nolanlawson left a comment

I tested this out in Firefox/Chrome/Safari on Mac and Edge on Windows. Every command is working great in all four browsers except that there is a small bug for the r and m commands where it actually puts the literal letter r or m in the compose box. This bug occurs in Chrome, Safari, and Edge, but not in Firefox.

@Kjwon15

This comment has been minimized.

Copy link
Contributor

Kjwon15 commented Oct 2, 2017

Great feature!
How about h/, l/ to move between columns like Tweetdeck does?

@akihikodaki akihikodaki added the ui label Oct 3, 2017

@Gargron Gargron force-pushed the feature-hotkeys branch from 5a8db84 to 9c075b5 Oct 3, 2017

Fix #2102 - Implement hotkeys
Hotkeys on status list:

- r to reply
- m to mention author
- f to favourite
- b to boost
- enter to open status
- p to open author's profile
- up or k to move up in the list
- down or j to move down in the list
- 1-9 to focus a status in one of the columns
- n to focus the compose textarea
- alt+n to start a brand new toot
- backspace to navigate back

@Gargron Gargron force-pushed the feature-hotkeys branch from 9c075b5 to ff7b1b6 Oct 3, 2017

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Oct 3, 2017

@nolanlawson I fixed that, I also made the hotkeys work in notifications column and detailed status view!

@Gargron Gargron changed the title Fix #2102 - Implement hotkeys Implement hotkeys for web UI Oct 3, 2017

Gargron added some commits Oct 3, 2017

Add navigational hotkeys
The key g followed by:

- s: start
- h: home
- n: notifications
- l: local timeline
- t: federated timeline
- f: favourites
- u: own profile
- p: pinned toots
- b: blocked users
- m: muted users

@Gargron Gargron referenced this pull request Oct 3, 2017

Merged

Bump version to 2.0.0rc1 #5209

14 of 14 tasks complete
@ykzts

ykzts approved these changes Oct 5, 2017

Addressed!

@Gargron Gargron merged commit 7db0f8d into master Oct 5, 2017

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Gargron Gargron deleted the feature-hotkeys branch Oct 5, 2017

@channprj

This comment has been minimized.

Copy link

channprj commented Oct 10, 2017

@Gargron Nice feature! Thank you for your work 👍 🎉
But there's no keyboard shortcut modal, so end user do not know about it.
How about shift + / to show up keyboard shortcut modal like below?

2017-10-11 00 26 56

rutan added a commit to rutan/mastodon that referenced this pull request Oct 11, 2017

Implement hotkeys for web UI (tootsuite#5164)
* Fix tootsuite#2102 - Implement hotkeys

Hotkeys on status list:

- r to reply
- m to mention author
- f to favourite
- b to boost
- enter to open status
- p to open author's profile
- up or k to move up in the list
- down or j to move down in the list
- 1-9 to focus a status in one of the columns
- n to focus the compose textarea
- alt+n to start a brand new toot
- backspace to navigate back

* Add navigational hotkeys

The key g followed by:

- s: start
- h: home
- n: notifications
- l: local timeline
- t: federated timeline
- f: favourites
- u: own profile
- p: pinned toots
- b: blocked users
- m: muted users

* Add hotkey for focusing search, make escape un-focus compose/search

* Fix focusing notifications column, fix hotkeys in compose textarea

takayamaki added a commit to takayamaki/mastodon that referenced this pull request Oct 12, 2017

Implement hotkeys for web UI (tootsuite#5164)
* Fix tootsuite#2102 - Implement hotkeys

Hotkeys on status list:

- r to reply
- m to mention author
- f to favourite
- b to boost
- enter to open status
- p to open author's profile
- up or k to move up in the list
- down or j to move down in the list
- 1-9 to focus a status in one of the columns
- n to focus the compose textarea
- alt+n to start a brand new toot
- backspace to navigate back

* Add navigational hotkeys

The key g followed by:

- s: start
- h: home
- n: notifications
- l: local timeline
- t: federated timeline
- f: favourites
- u: own profile
- p: pinned toots
- b: blocked users
- m: muted users

* Add hotkey for focusing search, make escape un-focus compose/search

* Fix focusing notifications column, fix hotkeys in compose textarea

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017

Implement hotkeys for web UI (tootsuite#5164)
* Fix tootsuite#2102 - Implement hotkeys

Hotkeys on status list:

- r to reply
- m to mention author
- f to favourite
- b to boost
- enter to open status
- p to open author's profile
- up or k to move up in the list
- down or j to move down in the list
- 1-9 to focus a status in one of the columns
- n to focus the compose textarea
- alt+n to start a brand new toot
- backspace to navigate back

* Add navigational hotkeys

The key g followed by:

- s: start
- h: home
- n: notifications
- l: local timeline
- t: federated timeline
- f: favourites
- u: own profile
- p: pinned toots
- b: blocked users
- m: muted users

* Add hotkey for focusing search, make escape un-focus compose/search

* Fix focusing notifications column, fix hotkeys in compose textarea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.