Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In thread view, only scroll first update, scroll to replied-to post #5322

Merged
merged 1 commit into from Oct 11, 2017

Conversation

@Gargron
Copy link
Member

commented Oct 11, 2017

  • Only perform the "scroll into view" on first update, not when e.g. additional replies are appended
  • Instead of scrolling to the focused status, scroll to the replied-to status, but align that scroll to top
@Gargron Gargron added the ui label Oct 11, 2017
@nolanlawson

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2017

This LGTM, one small issue I can see is

  1. You load toot # 4 in a thread
  2. Toot # 3 is scrolled to
  3. Toots # 1 and # 2 are loaded later, and they're above the fold

So you might not realize that 1 and 2 exist unless you think to scroll up.

But then again it'd probably be too distracting if it kept scrolling to the top as new ancestor toots come in, so 👍 from me.

@unarist

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2017

For nolan's concern, I think it would be nice if we scroll to toot # 3 with some offset.

@Gargron

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2017

Toots # 1 and # 2 are loaded later, and they're above the fold

This does not happen, all ancestors are loaded at once

@Gargron Gargron merged commit 1823cf4 into master Oct 11, 2017
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nolanlawson

This comment has been minimized.

Copy link
Collaborator

commented Oct 11, 2017

@Gargron That's odd, maybe we're talking about two different things. This is what I saw, in both Chrome and Firefox: https://gfycat.com/FriendlyFlawlessGermanwirehairedpointer

@Gargron Gargron deleted the fix-scroll-into-view branch Oct 11, 2017
@Gargron

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2017

Your gif shows the behaviour that I intended 🤔

@nolanlawson

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.