Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce discrepancies between server and client-side character count #5360

Merged
merged 1 commit into from Oct 12, 2017

Conversation

@ThibG
Copy link
Collaborator

commented Oct 12, 2017

There are various occasions where client-side and server-side toot character count disagree, potentially leading to rejected toots even though the web UI displays a non-negative number of available characters.

While I am pretty sure there are still discrepancies in the URL parsing code, this PR fixes a small mismatch in the regular expressions used for mentions.

@ThibG ThibG requested a review from Gargron Oct 12, 2017
@ykzts
ykzts approved these changes Oct 12, 2017
@Gargron Gargron merged commit d37305c into tootsuite:master Oct 12, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ThibG ThibG deleted the ThibG:mention-character-count branch Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.