New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retoot count increases without reason #5363

Merged
merged 3 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@cacheflow
Copy link
Contributor

cacheflow commented Oct 12, 2017

-The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
-This calls it when the transaction is finished by using after_create_commit.
-Fixes #4916.

Retoot count increases without reason
-The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
-This calls it when the transaction is finished by using after_create_commit.
-Fixes #4916.

@cacheflow cacheflow referenced this pull request Oct 12, 2017

Closed

Retoot count increases without reason #4916

2 of 2 tasks complete
@quin

This comment has been minimized.

Copy link

quin commented Oct 12, 2017

wow thanks! @cacheflow great work bud!

@quin

This comment has been minimized.

Copy link

quin commented Oct 12, 2017

looking small!

@quin

This comment has been minimized.

Copy link

quin commented Oct 12, 2017

stay small @cacheflow !

@krainboltgreene

This comment has been minimized.

Copy link
Member

krainboltgreene commented Oct 12, 2017

Great catch.

@Gargron Gargron merged commit b8bae96 into tootsuite:master Oct 13, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@quin

This comment has been minimized.

Copy link

quin commented Oct 13, 2017

please reverse this. this exposes a very bad bug which my machine crash.

I'm using windows 95, v1.9.47 on a chrome browser to reproduce

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017

Retoot count increases without reason (tootsuite#5363)
* Retoot count increases without reason

-The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
-This calls it when the transaction is finished by using after_create_commit.
-Fixes tootsuite#4916.

* Added test case for after_create_commit callback for checking reblog count.

* Rewrote test to keep original, but added one for only the after_create_commit callback.

abcang added a commit to pixiv/mastodon that referenced this pull request Nov 27, 2017

Retoot count increases without reason (tootsuite#5363)
* Retoot count increases without reason

-The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
-This calls it when the transaction is finished by using after_create_commit.
-Fixes tootsuite#4916.

* Added test case for after_create_commit callback for checking reblog count.

* Rewrote test to keep original, but added one for only the after_create_commit callback.

abcang added a commit to pixiv/mastodon that referenced this pull request Dec 18, 2017

Retoot count increases without reason (tootsuite#5363)
* Retoot count increases without reason

-The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice.
-This calls it when the transaction is finished by using after_create_commit.
-Fixes tootsuite#4916.

* Added test case for after_create_commit callback for checking reblog count.

* Rewrote test to keep original, but added one for only the after_create_commit callback.

abcang added a commit to pixiv/mastodon that referenced this pull request Dec 18, 2017

Merge pull request tootsuite#727 from pixiv/fix/reblog_count
Retoot count increases without reason (tootsuite#5363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment