Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close connection when succeeded posting #5390

Merged

Conversation

@abcang
Copy link
Collaborator

commented Oct 14, 2017

Since we do not need to read the body, close the connection without using flush.

Related: #5128

Also, to pass the test we need to use a webmock that is compatible with the new http.rb. (bblimke/webmock#721)

abcang added 2 commits Oct 14, 2017
Copy link
Member

left a comment

🎊

@Gargron Gargron merged commit 2eab41c into tootsuite:master Oct 14, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017
* Close connection when succeeded posting

* Update webmock
@abcang abcang deleted the abcang:close_connection_when_succeeded_posting branch Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.