Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capture scheme-less URLs in the status (regression from #4941) #5435

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@unarist
Copy link
Collaborator

commented Oct 17, 2017

Specifically, this fixes status length calculation to be same as JS side. (fixes #5433)

BTW, since this pattern used in not only preview card fetching, we should extract it (with twitter-regex?) and write tests I think.

Don't capture scheme-less URLs in the status
Specifically, this fixes status length calculation to be same as JS side.

BTW, since this pattern used in not only preview card fetching, we
should extract it (with twitter-regex?) and write tests I think.

@unarist unarist added the bug label Oct 17, 2017

@Gargron Gargron merged commit 3bc8924 into tootsuite:master Oct 17, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Oct 20, 2017

Don't capture scheme-less URLs in the status (tootsuite#5435)
Specifically, this fixes status length calculation to be same as JS side.

BTW, since this pattern used in not only preview card fetching, we
should extract it (with twitter-regex?) and write tests I think.

@unarist unarist deleted the unarist:fix/scheme-less-urls branch Sep 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.