Join GitHub today
Eliminate space around emoji #5474
I think this PR is important because Slack has the same behavior (There is no space around custom emojis) and people importing custom emojis from Slack would be disappointed to look space around emojis they added.
I made a change not to modify unicode emoji's behavior. Because of that, this PR affects only custom emojis now. We can add spaces by editing image for custom emojis, so I think there is little concern about custom emojis.
And in regard to padding-top, how about decreasing status__action-bar's margin-top from 10px to 5px. This modification sets off the increase of the height (I already applied this modification in the above screenshot).
From a viewpoint of design,
It's my opinion, I’d like to ask other opinions.
It's not bad, thanks.
I like this because some users make a big emoji by concatenating them like looooong fox. Another approach I think is better is to emojify with no space, not to change the appearance. For example,
This is also convenient for those who don't prefer a space between a word and an emoji. Japanese has no space unlike English, so I often glue a word and an emoji together, e.g.
To emojify with no space is not easy because a shortcode is closed with two colons. In other words we must discriminate between first colon and last colon. But I have implemented it before in other project. I'll make a pull request if this approach is favored a lot and no one doesn't do.
I'd also like to ask your opinions.
Nov 7, 2017
added a commit
this pull request
Nov 8, 2017
This PR makes emojis as large as they overflow height of letters, so it is impossible to keep exactly the same as before.
This PR reduces the margin between status text and action buttons from 10px to 5px. Should it be also restored? (I think 5px is enough, ummm)