Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID3v{1,2} and Vorbis metadata to boop #5531

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
5 participants
@yipdw
Copy link
Contributor

commented Oct 25, 2017

Inspired by https://awoo.space/@noiob/98889877558300456.

ogginfo results on boop.ogg after this PR:

$ ogginfo boop.ogg 
Processing file "boop.ogg"...

New logical stream (#1, serial: d23ff368): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Lavf57.72.100
Channels: 1
Rate: 44100

Nominal bitrate: 80.000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
        ENCODER=Lavc57.92.100 libvorbis
        TITLE=boop
        ARTIST=jk@mastodon.social
        DATE=2017
Vorbis stream 1:
        Total data length: 1812 bytes
        Playback length: 0m:00.235s
        Average bitrate: 61.658333 kb/s
Logical stream 1 ended

id3v2 -l results on boop.mp3:

$ id3v2 -l boop.mp3 
id3v1 tag info for boop.mp3:
Title  : boop                            Artist: jk@mastodon.social            
Album  :                                 Year: 2017, Genre: Unknown (255)
Comment:                                 Track: 0
id3v2 tag info for boop.mp3:
TSSE (Software/Hardware and settings used for encoding): 
TLEN (Length): 450
APIC (Attached picture): ()[, 0]: image/png, 8714 bytes
TIT2 (Title/songname/content description): boop
TPE1 (Lead performer(s)/Soloist(s)): jk@mastodon.social
TYER (Year): 2017

Size difference with master:

  • boop.mp3: 12070 -> 12280 bytes (+210 bytes)
  • boop.ogg: 5164 -> 5220 bytes (+56 bytes)

Embedded cover art (only in the MP3, I couldn't find a way to embed it as Vorbis metadata without unacceptably huge filesize increases):

media2

@noiob

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

Thank you.

@yiskah

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

I heard in the thread you were trying to make a rotatey gif the album art and I would caution against that. If there's album art it should be static

@yipdw

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2017

It is static; throwing in the entire animation would have added something like a megabyte to the filesize.

@yipdw

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2017

There may exist a licensing issue with the cover art: it's a derivative work of @jk@mastodon.social's avatar, and for this to go through it would have to be covered under AGPLv3 (or appropriate notations need to be made in the Mastodon license data, etc.) Probably should ask @jk@mastodon.social about this.

@yipdw yipdw force-pushed the yipdw:boop-metadata branch from 2bbe513 to 5c11e81 Oct 25, 2017

@yipdw

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2017

@jk@mastodon.social approved the derivative work:

I have also updated the comment field in the ID3 and Vorbis metadata as per his request. New metadata:

$ id3v2 -l boop.mp3 
id3v1 tag info for boop.mp3:
Title  : boop                            Artist: @jk@mastodon.social           
Album  :                                 Year: 2017, Genre: Unknown (255)
Comment: josefkenny.com                  Track: 0
id3v2 tag info for boop.mp3:
TSSE (Software/Hardware and settings used for encoding): 
TLEN (Length): 450
APIC (Attached picture): ()[, 0]: image/png, 8714 bytes
TIT2 (Title/songname/content description): boop
TPE1 (Lead performer(s)/Soloist(s)): @jk@mastodon.social
COMM (Comments): ()[eng]: josefkenny.com
TYER (Year): 2017
$ ogginfo boop.ogg 
Processing file "boop.ogg"...

New logical stream (#1, serial: d23ff368): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Lavf57.72.100
Channels: 1
Rate: 44100

Nominal bitrate: 80.000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
        ENCODER=Lavc57.92.100 libvorbis
        TITLE=boop
        ARTIST=@jk@mastodon.social
        DATE=2017
        COMMENT=josefkenny.com
Vorbis stream 1:
        Total data length: 1812 bytes
        Playback length: 0m:00.235s
        Average bitrate: 61.658333 kb/s
Logical stream 1 ended
Add artist, title, and date metadata to boop.{mp3,ogg}
For boop.mp3, this commit adds both ID3v1 and ID3v2 tags.  For boop.ogg,
we use Vorbis metadata.

In the case of boop.mp3, this also adds a cover image. Interestingly, it
didn't seem to affect the size of boop.mp3 much, despite being ~8k.
boop.ogg seemed to be much more affected and so no cover image was added
to that version.

@yipdw yipdw force-pushed the yipdw:boop-metadata branch from 5c11e81 to 8a6744b Oct 25, 2017

@unarist unarist merged commit 37b267e into tootsuite:master Oct 27, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.