Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open a modal for embedded photo #5777

Merged
merged 1 commit into from Nov 25, 2017

Conversation

@akihikodaki
Copy link
Collaborator

commented Nov 21, 2017

screenshot-2017-11-21 mastodon dev

@akihikodaki akihikodaki added the ui label Nov 21, 2017
@akihikodaki akihikodaki force-pushed the kagucho:open branch 3 times, most recently from 77f9eaf to d18a4f7 Nov 21, 2017
@akihikodaki

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 21, 2017

For anyone interested in testing this change: the screenshot shows a picture on pixiv, but pictures on pixiv no longer looks so nice because it reports height incorrectly and height is now used for the layout of the modal. Use other standard-conforming oEmbed providers for testing.

@akihikodaki akihikodaki force-pushed the kagucho:open branch from d18a4f7 to 039895d Nov 21, 2017
@akihikodaki akihikodaki force-pushed the kagucho:open branch from 039895d to f83af96 Nov 21, 2017
@ykzts
ykzts approved these changes Nov 25, 2017
Copy link
Collaborator

left a comment

nice!

@Gargron Gargron merged commit bf7757c into tootsuite:master Nov 25, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017
@akihikodaki akihikodaki referenced this pull request Dec 11, 2017
1 of 2 tasks complete
kaniini added a commit to kaniini/mastodon that referenced this pull request Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.