Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard Shortcuts Legend #5823

Merged
merged 2 commits into from Nov 27, 2017

Conversation

Projects
None yet
4 participants
@joshuap
Copy link
Contributor

joshuap commented Nov 26, 2017

This adds a "Keyboard Shortcuts" legend (displayed in the rightmost column) which is toggled via a new "?" hotkey. When subsequently pressed from the Keyboard Shortcuts legend, "?" will navigate back to the previous location:

keyboard-shortcuts

I copied the hotkeys/legend directly from #5164; let me know if I'm missing any. I'm still getting familiar with the codebase.

Fixes #5573

Add Keyboard Shortcuts Legend
Adds a "Keyboard Shortcuts" legend (displayed in the rightmost column)
which is toggled via a new "?" hotkey. When subsequently pressed from
the Keyboard Shortcuts legend, "?" will navigate back to the previous
location.
@sorin-davidoi
Copy link
Collaborator

sorin-davidoi left a comment

Just a small nitpick - thanks for taking the time to fix this! 😄

return (
<Column icon='question' heading={intl.formatMessage(messages.heading)} hideHeadingOnMobile>
<div className='keyboard-shortcuts scrollable optionally-scrollable'>
<table>

This comment has been minimized.

@sorin-davidoi

sorin-davidoi Nov 26, 2017

Collaborator

I would add the header rows for accessibility reasons - we can give them height: 0 if we decide to hide them for aesthetic reasons.

This comment has been minimized.

@joshuap

joshuap Nov 26, 2017

Author Contributor

@sorin-davidoi take a look at 2ec97c1 ? I used a different CSS technique which should work for accessibility (had trouble getting height: 0; to work with the table, but if you want to suggest some CSS I'm happy to revise again).

Add hidden table headings.
Makes the headings available for accessibility but hides them visually.

@akihikodaki akihikodaki added the ui label Nov 27, 2017

@Gargron Gargron merged commit ff78c11 into tootsuite:master Nov 27, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

SerCom-KC added a commit to SerCom-KC/mastodon that referenced this pull request Nov 29, 2017

ykzts added a commit that referenced this pull request Dec 5, 2017

Update Chinese (Simplified) translations for version 2.1.0rc1 (#5849)
* i18n: (zh-CN) Add missing translations for multiple PRs.
Related PRs: #5838 #5762 #5835 #5837 #5832 #5823 #5814 #5757

* i18n: (zh-CN) Fix translation for #5823 / #5835

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Change `发送者` to `作者`

* i18n: (zh-CN) Add missing translations for #5862

* i18n: (zh-CN) Add missing translation for #5874

* i18n: (zh-CN) Improve translations for keyboard shortcuts

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017

Add Keyboard Shortcuts Legend (tootsuite#5823)
* Add Keyboard Shortcuts Legend

Adds a "Keyboard Shortcuts" legend (displayed in the rightmost column)
which is toggled via a new "?" hotkey. When subsequently pressed from
the Keyboard Shortcuts legend, "?" will navigate back to the previous
location.

* Add hidden table headings.

Makes the headings available for accessibility but hides them visually.

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017

Update Chinese (Simplified) translations for version 2.1.0rc1 (tootsu…
…ite#5849)

* i18n: (zh-CN) Add missing translations for multiple PRs.
Related PRs: tootsuite#5838 tootsuite#5762 tootsuite#5835 tootsuite#5837 tootsuite#5832 tootsuite#5823 tootsuite#5814 tootsuite#5757

* i18n: (zh-CN) Fix translation for tootsuite#5823 / tootsuite#5835

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Change `发送者` to `作者`

* i18n: (zh-CN) Add missing translations for tootsuite#5862

* i18n: (zh-CN) Add missing translation for tootsuite#5874

* i18n: (zh-CN) Improve translations for keyboard shortcuts

kaniini added a commit to kaniini/mastodon that referenced this pull request Mar 9, 2018

Add Keyboard Shortcuts Legend (tootsuite#5823)
* Add Keyboard Shortcuts Legend

Adds a "Keyboard Shortcuts" legend (displayed in the rightmost column)
which is toggled via a new "?" hotkey. When subsequently pressed from
the Keyboard Shortcuts legend, "?" will navigate back to the previous
location.

* Add hidden table headings.

Makes the headings available for accessibility but hides them visually.

kaniini added a commit to kaniini/mastodon that referenced this pull request Mar 9, 2018

Update Chinese (Simplified) translations for version 2.1.0rc1 (tootsu…
…ite#5849)

* i18n: (zh-CN) Add missing translations for multiple PRs.
Related PRs: tootsuite#5838 tootsuite#5762 tootsuite#5835 tootsuite#5837 tootsuite#5832 tootsuite#5823 tootsuite#5814 tootsuite#5757

* i18n: (zh-CN) Fix translation for tootsuite#5823 / tootsuite#5835

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Improve translations

* i18n: (zh-CN) Change `发送者` to `作者`

* i18n: (zh-CN) Add missing translations for tootsuite#5862

* i18n: (zh-CN) Add missing translation for tootsuite#5874

* i18n: (zh-CN) Improve translations for keyboard shortcuts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.