New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit by user instead of IP when API user is authenticated #5923

Merged
merged 3 commits into from Dec 9, 2017

Conversation

Projects
None yet
3 participants
@Gargron
Member

Gargron commented Dec 8, 2017

@aschmitz

This looks good overall. The limit might be a bit low for some API clients, but it looks like that's already the existing limit, so I guess it's probably fine for now.

Show outdated Hide outdated config/initializers/rack_attack.rb Outdated

Gargron added some commits Dec 8, 2017

@abcang

abcang approved these changes Dec 9, 2017

@Gargron Gargron merged commit a865b62 into master Dec 9, 2017

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Gargron Gargron deleted the fix-ip-rate-limit branch Dec 9, 2017

kaniini added a commit to kaniini/mastodon that referenced this pull request Mar 9, 2018

Rate limit by user instead of IP when API user is authenticated (toot…
…suite#5923)

* Fix tootsuite#668 - Rate limit by user instead of IP when API user is authenticated

* Fix code style issue

* Use request decorator provided by Doorkeeper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment