Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#255 – Collapsable toots! #658

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
@marrus-sh
Copy link
Contributor

marrus-sh commented Mar 1, 2017

Automatically collapses toots in timelines whose text contents are taller than 200px tall, with a button at the bottom to expand. Doesn't look at toots with spoiler/content warnings, so hypothetically if someone really wanted to fill up your feed with long toots they could abuse that. I don't really see that being a problem though.

@yiskah

This comment has been minimized.

Copy link
Contributor

yiskah commented Mar 2, 2017

I imagine this would solve the problem of encountering instances without character limits posting entire articles as well?

@yiskah

This comment has been minimized.

Copy link
Contributor

yiskah commented Mar 31, 2017

Hey @Gargron is this Pull mergable right now? It would help address some of the harassment/spamming concerns that have been brought up in relation to someone making instances for the purpose of spamming. Since a post could not be too long if collapsed.

@haniawni

This comment has been minimized.

Copy link

haniawni commented Mar 31, 2017

With the recent influx of new users remarking on the prevalence of bots, I dug through my blocklist- plenty of the ones I've blocked are blocked because they just post immense toots.

This pull is exceedingly relevant to new users and will help with harassment in the future; is there any technical reason why this has not been already merged?
Thanks!

@Pajn Pajn referenced this pull request Apr 6, 2017

Closed

Users can spam timeline with extremely tall posts #1072

1 of 1 task complete
@sethmlarson

This comment has been minimized.

Copy link

sethmlarson commented Apr 6, 2017

This feature is desperately needed.

@@ -87,6 +91,11 @@ const StatusContent = React.createClass({
this.setState({ hidden: !this.state.hidden });
},

handleCollapsedClick (e) {
e.preventDefault();
this.setState({ collapsed: !this.state.collapsed });

This comment has been minimized.

@ineffyble

ineffyble Apr 8, 2017

Collaborator

Is this setting collapsed to !null? Does that result in false? A little unsure of the value flow here.

This comment has been minimized.

@Pajn

Pajn Apr 8, 2017

It flips the boolean. If collapsed is null, it will set collapsed to true as null is falsey.
However, as handleCollapsedClick only is used when collapsed is not null that case wont happen.

@ineffyble ineffyble requested a review from Gargron Apr 8, 2017

@Gargron Gargron added the ui label Apr 8, 2017

@dcl

This comment has been minimized.

Copy link

dcl commented Apr 12, 2017

Hey, what's the status on getting this merged?

@yiskah yiskah assigned yiskah, Gargron and blackle and unassigned yiskah Apr 12, 2017

@yiskah

This comment has been minimized.

Copy link
Contributor

yiskah commented Apr 12, 2017

We need it to be reviewed by probably gargron before merging

@yiskah

yiskah approved these changes Apr 23, 2017

@ashfurrow

This comment has been minimized.

Copy link
Collaborator

ashfurrow commented Apr 29, 2017

@marrus-sh thanks for the pull request! Sorry it's bene hanging around with no resolution. It looks like there are a few merge conflicts. Would you be able to pull from latest and review the changes? There are a few CodeClimate issues to resolve too. Then we can ping Gargron and see about getting this merged. Thanks again!

@ProgVal ProgVal referenced this pull request Jun 15, 2017

Closed

Collapsible toots #3779

abcang added a commit to pixiv/mastodon that referenced this pull request Nov 15, 2017

lanodan added a commit to lanodan/mastodon that referenced this pull request Aug 14, 2018

lanodan added a commit to lanodan/mastodon that referenced this pull request Aug 21, 2018

lanodan added a commit to lanodan/mastodon that referenced this pull request Aug 27, 2018

ensra pushed a commit to ensra/mastofe that referenced this pull request Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.