New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenient colour palettes #659

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@marrus-sh
Contributor

marrus-sh commented Mar 1, 2017

This doesn't change anything about the site, but it does add some handy colour palettes (Tango, Solarized, etc) in variables/palettes.scss to make customizing your instance as easy as substituting one variable name for another.

@ineffyble

This comment has been minimized.

Collaborator

ineffyble commented Apr 8, 2017

Ooh, I like it.

@Gargron Gargron added the ui label Apr 8, 2017

@expenses

This comment has been minimized.

Contributor

expenses commented Apr 11, 2017

Looks good. I suppose there could be concerns about bloat with this sort of thing, but we definitely want to put colours into a separate file to avoid 'magic numbers'.

@mjankowski

Thanks for collecting all of these -- can you explain a little more about how these would be intended to be used?

I have some concern that we should improve the variable usage throughout the project first before adding "themes" or color-sets.

Separately, this PR needs a rebase.

@ashfurrow

This comment has been minimized.

Collaborator

ashfurrow commented Apr 29, 2017

Cool idea! Thanks for the PR @marrus-sh. I think now that we have the ability to add custom CSS maybe some documentation could be added too. Could you rebase with the latest changes from master?

@ashfurrow

This comment has been minimized.

Collaborator

ashfurrow commented May 6, 2017

Any update on this @marrus-sh ?

@ashfurrow

This comment has been minimized.

Collaborator

ashfurrow commented May 13, 2017

Hi there, thanks for the pull request! It's been a few weeks with no updates, and #2912 has been merged which addresses the same problem. I'm going to close this pull request, but if you'd like to discuss it further please don't hesitate to open a new one, or an issue. Thanks again!

@ashfurrow ashfurrow closed this May 13, 2017

abcang added a commit to pixiv/mastodon that referenced this pull request Sep 15, 2017

abcang added a commit to pixiv/mastodon that referenced this pull request Nov 15, 2017

Merge pull request tootsuite#659 from pixiv/revert-645-status_index
Revert "Improve status index on music"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment