Make scroll bars wider

[sts10]

I think the scroll bars on Mastodon's front-end could be a bit wider than 8px. I probably didn't execute this exactly right, but I tried to bump it up to 12px in basics.scss (I admittedly did not spend a lot of time trying to figure out which scss file).

Also, I couldn't figure out how to test this cuz I couldn't figure out how to install Ruby 2.5.1 on my machine :(

So in general this is not a great PR haha. But my request still stands -- wider scroll bars would be nice.

[Gargron]

It's here: https://github.com/sts10/mastodon/blob/d7233d046d607557c1b6f54f402c812b122522fe/app/javascript/styles/mastodon/reset.scss#L56-L59

[sts10]

Sorry, bit confused by your request for changes. Do you want (a) me to change the width and height to 12px in the reset.scss file rather than in the basics.scss file or (b) remove scrollbar height and width specifications altogether.

I think (a) is a strange move-- generally css reset files serve the purpose of zeroing out or normalizing properties so that ever user has the same defaults, reducing browser inconsistencies. Hence why, in my original PR, I chose to "overwrite" the 8px in basics.scss.

Thus, in these new changes, I assumed you meant I should take route (b)-- remove the scrollbar height and width specifications altogether. My hope here is that browsers will fall back on some sort of system setting, which will like be wide enough to click and drag. This could even be a good move from an accessibility stand point.

Let me know if that was not the change you were thinking of.

[sts10]

Sorry, bit confused by your request for changes. Do you want (a) me to change the width and height to 12px in the reset.scss file rather than in the basics.scss file or (b) remove scrollbar height and width specifications altogether.

I think (a) is a strange move-- generally css reset files serve the purpose of zeroing out or normalizing properties so that ever user has the same defaults, reducing browser inconsistencies. Hence why, in my original PR, I chose to "overwrite" the 8px in basics.scss.

Thus, in these new changes, I assumed you meant I should take route (b)-- remove the scrollbar height and width specifications altogether. My hope here is that browsers will fall back on some sort of system setting, which will like be wide enough to click and drag. This could even be a good move from an accessibility stand point.

Let me know if that was not the change you were thinking of.

[sts10]

Psyched that this got merged! My first contribution to Mastodon!

I'm assuming you've tested this on a few browsers and it looks good? I'm only worried cuz I have yet to get Mastodon to run locally (due to unrelated Ruby gem problems on my home machine), and I can't quite produce it via Chrome's Inspect Element.

[sts10]

Psyched that this got merged! My first contribution to Mastodon!

I'm assuming you've tested this on a few browsers and it looks good? I'm only worried cuz I have yet to get Mastodon to run locally (due to unrelated Ruby gem problems on my home machine), and I can't quite produce it via Chrome's Inspect Element.

[nightpool]

yeah i think this broke scrollbars on chrome

[nightpool]

yeah i think this broke scrollbars on chrome

[sts10]

Ack, that's what I was worried about.

Maybe we should just change the hard-coded 8px to 12px, either in basics.scss or reset.scss, rather than removing the specification altogether.

[sts10]

Ack, that's what I was worried about.

Maybe we should just change the hard-coded 8px to 12px, either in basics.scss or reset.scss, rather than removing the specification altogether.