Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RuboCop error #7442

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@kibitan
Copy link
Contributor

kibitan commented May 10, 2018

RuboCop doesn't work by following error.

$ rubocop
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)

it comes from RuboCop 0.53.0 [Fix #3394] Separate Array & Hash Literal Comma configuration by garettarrowood · Pull Request #5307 · bbatsov/rubocop

fix RuboCop error
RuboCop doesn't work by following error.

```
$ rubocop
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
```

it comes from RuboCop 0.53.0 [\[Fix #3394\] Separate Array & Hash Literal Comma configuration by garettarrowood · Pull Request #5307 · bbatsov/rubocop](rubocop-hq/rubocop#5307)
@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented May 10, 2018

This breaks codeclimate, which is still on an older rubocop version.

@kibitan

This comment has been minimized.

Copy link
Contributor Author

kibitan commented May 10, 2018

@Gargron hmm, how should I treat this, specify RuboCop version on CodeClimate ( but it's available until 0.54 ) or downgrade projects RuboCop or just fix this issues?

@Gargron

Gargron approved these changes Jun 4, 2018

@Gargron Gargron merged commit 1637d24 into tootsuite:master Jun 4, 2018

8 of 9 checks passed

codeclimate 30 issues to fix
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details

lawremipsum added a commit to lawremipsum/mspsocial-mastodon that referenced this pull request Jul 7, 2018

fix RuboCop error (tootsuite#7442)
* fix RuboCop error

RuboCop doesn't work by following error.

```
$ rubocop
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
```

it comes from RuboCop 0.53.0 [\[Fix tootsuite#3394\] Separate Array & Hash Literal Comma configuration by garettarrowood · Pull Request tootsuite#5307 · bbatsov/rubocop](rubocop-hq/rubocop#5307)

* ci(CodeClimate): specify RuboCop version 0.54

 * https://docs.codeclimate.com/docs/rubocop#section-using-rubocop-s-newer-versions
 * [RuboCop 0.55.0 is not available yet](codeclimate/codeclimate-rubocop#121) on CodeClimate rubocop channel

abcang added a commit to pixiv/mastodon that referenced this pull request Jul 31, 2018

fix RuboCop error (tootsuite#7442)
* fix RuboCop error

RuboCop doesn't work by following error.

```
$ rubocop
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
```

it comes from RuboCop 0.53.0 [\[Fix tootsuite#3394\] Separate Array & Hash Literal Comma configuration by garettarrowood · Pull Request tootsuite#5307 · bbatsov/rubocop](rubocop-hq/rubocop#5307)

* ci(CodeClimate): specify RuboCop version 0.54

 * https://docs.codeclimate.com/docs/rubocop#section-using-rubocop-s-newer-versions
 * [RuboCop 0.55.0 is not available yet](codeclimate/codeclimate-rubocop#121) on CodeClimate rubocop channel

abcang added a commit to pixiv/mastodon that referenced this pull request Jul 31, 2018

byronhulcher added a commit to byronhulcher/mastodon that referenced this pull request Aug 18, 2018

fix RuboCop error (tootsuite#7442)
* fix RuboCop error

RuboCop doesn't work by following error.

```
$ rubocop
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
```

it comes from RuboCop 0.53.0 [\[Fix tootsuite#3394\] Separate Array & Hash Literal Comma configuration by garettarrowood · Pull Request tootsuite#5307 · bbatsov/rubocop](rubocop-hq/rubocop#5307)

* ci(CodeClimate): specify RuboCop version 0.54

 * https://docs.codeclimate.com/docs/rubocop#section-using-rubocop-s-newer-versions
 * [RuboCop 0.55.0 is not available yet](codeclimate/codeclimate-rubocop#121) on CodeClimate rubocop channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.