Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude-other-silenced-accounts #7528

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
4 participants
@masarakki
Copy link
Contributor

commented May 17, 2018

Now, silenced users can show other silenced user's statuses, why is it necessary?

@masarakki masarakki force-pushed the masarakki:exclude-other-silenced-accounts branch from 52a16d4 to b9bea05 May 17, 2018

@nightpool

This comment has been minimized.

Copy link
Collaborator

commented May 18, 2018

Now, silenced users can show other silenced user's statuses, why is it necessary?

what do you mean by this? isn't this change actually the opposite? i.e. it prevents silenced users from seeing other silenced user's statuses?


 217/536 |======== 40 ========>                                |  ETA: 00:00:38 

  1) Status.as_public_timeline with an account passed in where that account is silenced includes statuses from other accounts that are silenced
     Failure/Error: expect(results).to include(other_status)
     
       expected #<ActiveRecord::Relation []> to include #<Status id: 100044383610076677, uri: "https://cb6e6126.ngrok.io/users/dejuan_schuppe188/...", text: ...onversation_id: 274, local: true, account_id: 312, application_id: nil, in_reply_to_account_id: nil>
       Diff:
       @@ -1,2 +1,2 @@
       -[#<Status id: 100044383610076677, uri: "https://cb6e6126.ngrok.io/users/dejuan_schuppe188/...", text: "Lorem ipsum dolor sit amet", created_at: "2018-05-17 11:22:26", updated_at: "2018-05-17 11:22:26", in_reply_to_id: nil, reblog_of_id: nil, url: nil, sensitive: false, visibility: "public", spoiler_text: "", reply: false, favourites_count: 0, reblogs_count: 0, language: nil, conversation_id: 274, local: true, account_id: 312, application_id: nil, in_reply_to_account_id: nil>]
       +[]
       
     # ./spec/models/status_spec.rb:548:in `block (5 levels) in <top (required)>'

you'll need to fix the failing test before merge

@masarakki masarakki force-pushed the masarakki:exclude-other-silenced-accounts branch from b9bea05 to 52e0bb4 May 26, 2018

@Gargron

This comment has been minimized.

Copy link
Member

commented Jun 16, 2018

@nightpool No, the change is somewhat correct. Our current behaviour is that silenced users only see other silenced users in the public timelines. It's like a hellban. This PR removes that behaviour.

@takayamaki

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2018

Are there any other concerns?

@Gargron Gargron merged commit 4bdab20 into tootsuite:master Aug 22, 2018

9 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@masarakki masarakki deleted the masarakki:exclude-other-silenced-accounts branch Aug 22, 2018

kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.