Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd profile options on compose form #7789
Conversation
added some commits
Jun 12, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Gargron
Jun 12, 2018
Member
About "Edit profile": Even if it's redundant, removing it would leave empty space that would look worse. Also, it's important enough that its discovery should be prioritized (people might not think of clicking on a dropdown icon). So yes, keeping it this way is good.
Does this play well with the "unfocus textarea" ("hide keyboard") icon that appears in that place on mobile when the textarea is focused?
Also since the hamburger icon is overused between getting started and here and also symbolizing lists, could you use the vertical ellipsis icon? (Three vertical dots)
|
About "Edit profile": Even if it's redundant, removing it would leave empty space that would look worse. Also, it's important enough that its discovery should be prioritized (people might not think of clicking on a dropdown icon). So yes, keeping it this way is good. Does this play well with the "unfocus textarea" ("hide keyboard") icon that appears in that place on mobile when the textarea is focused? Also since the hamburger icon is overused between getting started and here and also symbolizing lists, could you use the vertical ellipsis icon? (Three vertical dots) |


chr-1x commentedJun 12, 2018
•
edited
Edited 2 times
-
chr-1x
edited Jun 12, 2018 (most recent)
-
chr-1x
edited Jun 12, 2018
-
chr-1x
created Jun 12, 2018
As of 2.4.1 the only way to access mutes, blocks, and domain block options is from a submenu when viewing your own profile
This PR adds an action button to the compose form to expose the same options in a more convenient and discoverable way. It provides essentially the same menu options without reintroducing clutter to the getting started menu and using an intuitive connection (your profile information is already shown in the compose form, so options related to it, such as your mutes and domain blocks, make sense to access from this button).
May need some UI work, the button is a little low contrast right now. Also should be considered whether the "edit profile" link under your username is now redundant considering the same option is available in the new menu.