Add profile options on compose form #7789

Merged
merged 4 commits into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@chr-1x
Contributor

chr-1x commented Jun 12, 2018

As of 2.4.1 the only way to access mutes, blocks, and domain block options is from a submenu when viewing your own profile

This PR adds an action button to the compose form to expose the same options in a more convenient and discoverable way. It provides essentially the same menu options without reintroducing clutter to the getting started menu and using an intuitive connection (your profile information is already shown in the compose form, so options related to it, such as your mutes and domain blocks, make sense to access from this button).

May need some UI work, the button is a little low contrast right now. Also should be considered whether the "edit profile" link under your username is now redundant considering the same option is available in the new menu.

image
image

Andrew added some commits Jun 12, 2018

@Gargron

This comment has been minimized.

Show comment
Hide comment
@Gargron

Gargron Jun 12, 2018

Member

About "Edit profile": Even if it's redundant, removing it would leave empty space that would look worse. Also, it's important enough that its discovery should be prioritized (people might not think of clicking on a dropdown icon). So yes, keeping it this way is good.

Does this play well with the "unfocus textarea" ("hide keyboard") icon that appears in that place on mobile when the textarea is focused?

Also since the hamburger icon is overused between getting started and here and also symbolizing lists, could you use the vertical ellipsis icon? (Three vertical dots)

Member

Gargron commented Jun 12, 2018

About "Edit profile": Even if it's redundant, removing it would leave empty space that would look worse. Also, it's important enough that its discovery should be prioritized (people might not think of clicking on a dropdown icon). So yes, keeping it this way is good.

Does this play well with the "unfocus textarea" ("hide keyboard") icon that appears in that place on mobile when the textarea is focused?

Also since the hamburger icon is overused between getting started and here and also symbolizing lists, could you use the vertical ellipsis icon? (Three vertical dots)

@chr-1x

This comment has been minimized.

Show comment
Hide comment
@chr-1x

chr-1x Jun 13, 2018

Contributor

Latest commit makes it play nicely with the X button.
pr7789a

Also now uses the ellipsis-v icon instead of hamburger button. I do want to point out that this is inconsistent with the icon used on profiles, so maybe it should be changed both places?
image

Contributor

chr-1x commented Jun 13, 2018

Latest commit makes it play nicely with the X button.
pr7789a

Also now uses the ellipsis-v icon instead of hamburger button. I do want to point out that this is inconsistent with the icon used on profiles, so maybe it should be changed both places?
image

@Gargron Gargron merged commit 0338da1 into tootsuite:master Jun 13, 2018

9 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@wohali wohali referenced this pull request Jun 14, 2018

Closed

Mute/Block management interface is hard to find #7762

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment