New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update twemojie to v2 #7911

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@Dryusdan
Contributor

Dryusdan commented Jun 29, 2018

Twemojie add v2 and add some emojie. I push new twemojie

Dryusdan
@Gargron

This comment has been minimized.

Member

Gargron commented Jun 29, 2018

It's very difficult for me to review 2,841 changed files. Could you write down what you did so I can reproduce it? Is it the v11 release? https://github.com/twitter/twemoji/releases/tag/v11.0.0

@Dryusdan

This comment has been minimized.

Contributor

Dryusdan commented Jun 29, 2018

Hum, okay.

I clone https://github.com/twitter/twemoji, I going on twemojie/2/svg and I copy all svg file to mastodon's public/emoji folder :)

That all. (and it work on my instance)

@Gargron

Gargron approved these changes Jul 5, 2018

I followed the steps and arrived at the identical result, so if the twemoji repository is not compromised, this patch is clean.

@Gargron Gargron merged commit 17b9285 into tootsuite:master Jul 5, 2018

9 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@trwnh

This comment has been minimized.

Contributor

trwnh commented Jul 6, 2018

The file number seems high because there are a lot of SVGs being updated -- at minimum, for each SVG, metadata has been removed and paths have been simplified.

lawremipsum added a commit to lawremipsum/mspsocial-mastodon that referenced this pull request Jul 7, 2018

GenbuHase added a commit to Itabashi-don/mastodon that referenced this pull request Jul 31, 2018

byronhulcher added a commit to byronhulcher/mastodon that referenced this pull request Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment