New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace sabotaged uws with ws #8223

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@devkral
Copy link
Contributor

devkral commented Aug 16, 2018

Recently the uws package was sabotaged by its maintainer and causes now sometimes runtime errors.
see:
https://www.npmjs.com/package/uws
and
https://www.reddit.com/r/node/comments/91kgte/uws_has_been_deprecated/

Sorry for replacing a technical better solution by an inferior.

@devkral

This comment has been minimized.

Copy link
Contributor

devkral commented Aug 16, 2018

"npm run start" fails under some unknown circumstances and is not repairable.
I helped somebody setting up a mastodon instance. Sry, I forgot to ask for the log.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Aug 17, 2018

Hm. So I've read up on it and the developer released an empty version and deprecated the project (apparently in protest of npm semver practices??). But older versions should still be okay, right? Can we remain with uws until there an issue? Also, someone might fork it. I don't know the exact benchmarks between these libraries but some Mastodon servers handle very big loads so I would prefer not to sacrifice any performance whenever possible.

@nightpool

This comment has been minimized.

Copy link
Collaborator

nightpool commented Aug 18, 2018

npm packages are (to my understanding) immutable, so i don't think there's any problem with remaining on the current version.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Aug 18, 2018

In that case I will close this, but thank you for the submission.

@Gargron Gargron closed this Aug 18, 2018

@nightpool nightpool referenced this pull request Sep 30, 2018

Closed

uWS is no longer available via yarn/node #8833

2 of 2 tasks complete
@ddevault

This comment has been minimized.

Copy link
Contributor

ddevault commented Nov 27, 2018

It doesn't seem wise to stick with an unmaintained dependency as important as this. It seems like this ticket should be left open, or another filed, to track work moving away from this library.

Bonus: this library has been the single biggest frustration for me as an instance maintainer. It breaks with every goddamn update.

@nanaya

This comment has been minimized.

Copy link

nanaya commented Dec 8, 2018

My patch in #7710 seems to still work for replacing uws back to ws. Not sure about the performance though as I'm using it on my own single user instance so performance doesn't really matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment