New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing video descriptions #8416

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
2 participants
@dracos
Contributor

dracos commented Aug 24, 2018

This PR pulls through video descriptions through to where they are output, as they were present but not being displayed on videos. It also adds title attribute to videos, as requested. Fixes #8132.

@Gargron Gargron merged commit ac092d0 into tootsuite:master Aug 24, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018

Add missing video descriptions (tootsuite#8416)
* Pass through video description as necessary.

* Add title to video, matching aria-label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment