Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make detailed-status__wrapper actually wrap detailed status #8547

Merged
merged 2 commits into from Oct 30, 2018

Conversation

@trwnh
Copy link
Contributor

commented Sep 1, 2018

.detailed-status__wrapper does not actually wrap the detailed status right now, as the class is applied to the scrollable div and not the focusable div.

trwnh added 2 commits Sep 1, 2018
.detailed-status__wrapper does not actually wrap the detailed status here
.detailed-status__wrapper now wraps the detailed status instead of the entire scrollable area
@trwnh trwnh changed the title [WIP] Make detailed-status__wrapper actually wrap detailed status Make detailed-status__wrapper actually wrap detailed status Sep 1, 2018
@trwnh

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

Can this be reviewed before 2.6.0?

@Gargron

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

I'm sorry but could you please clarify the significance of this? Does something change in the style or JS behaviour?

@trwnh

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2018

@Gargron Right now, when attempting to apply styles to the div immediately wrapping a detailed status, there is no easy selector that can be used to target it. It doesn't matter so much for the default style, but it makes custom styling harder than it should be. It's incredibly overly-broad in scope:
image

It's also technically a bug, since the __wrapper class is immediately outside every other status class.

@Gargron Gargron merged commit 2cc099c into tootsuite:master Oct 30, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@trwnh trwnh deleted the trwnh:patch-2 branch Oct 30, 2018
cyber-gene pushed a commit to ikebuku-ro/mastodon that referenced this pull request Oct 31, 2018
* 'master' of github.com:tootsuite/mastodon: (23 commits)
  Bump version to 2.6.1 (tootsuite#9172)
  Fix reducer error when conversation has no last status in web UI (tootsuite#9173)
  Revert "Fix FetchAtomService  content type handling (tootsuite#9132)" (tootsuite#9171)
  Bump version to 2.6.0 (tootsuite#9149)
  [i18n] Update for Occitan (tootsuite#9169)
  Remove progress estimate from MigrateAccountConversations (tootsuite#9168)
  Specify node version to not use node11 (tootsuite#9166)
  Bump version to 2.6.0rc4 (tootsuite#9164)
  Fix empty display name precedence over username in web UI (tootsuite#9163)
  Fix td instead of th in sessions table header (tootsuite#9162)
  Revert "feat(auth/session_controller): Send Clear-Site-Data when logging out (8627)" (tootsuite#9161)
  Fix FetchAtomService  content type handling (tootsuite#9132)
  [i18n] Update for Occitan (tootsuite#9157)
  Accept the same payload in multiple inboxes and deliver (tootsuite#9150)
  Always let through notifications from staff (tootsuite#9152)
  Fix Pleroma mentions being fetched as preview cards (tootsuite#9158)
  [Security] Bump loofah from 2.2.2 to 2.2.3 (tootsuite#9160)
  Bump oj from 3.6.12 to 3.7.0 (tootsuite#9155)
  Make detailed-status__wrapper actually wrap detailed status (tootsuite#8547)
  Bump i18n-tasks from master to 0.9.28 (tootsuite#9148)
  ...
cyber-gene pushed a commit to ikebuku-ro/mastodon that referenced this pull request Oct 31, 2018
* 'master' of github.com:tootsuite/mastodon: (23 commits)
  Bump version to 2.6.1 (tootsuite#9172)
  Fix reducer error when conversation has no last status in web UI (tootsuite#9173)
  Revert "Fix FetchAtomService  content type handling (tootsuite#9132)" (tootsuite#9171)
  Bump version to 2.6.0 (tootsuite#9149)
  [i18n] Update for Occitan (tootsuite#9169)
  Remove progress estimate from MigrateAccountConversations (tootsuite#9168)
  Specify node version to not use node11 (tootsuite#9166)
  Bump version to 2.6.0rc4 (tootsuite#9164)
  Fix empty display name precedence over username in web UI (tootsuite#9163)
  Fix td instead of th in sessions table header (tootsuite#9162)
  Revert "feat(auth/session_controller): Send Clear-Site-Data when logging out (8627)" (tootsuite#9161)
  Fix FetchAtomService  content type handling (tootsuite#9132)
  [i18n] Update for Occitan (tootsuite#9157)
  Accept the same payload in multiple inboxes and deliver (tootsuite#9150)
  Always let through notifications from staff (tootsuite#9152)
  Fix Pleroma mentions being fetched as preview cards (tootsuite#9158)
  [Security] Bump loofah from 2.2.2 to 2.2.3 (tootsuite#9160)
  Bump oj from 3.6.12 to 3.7.0 (tootsuite#9155)
  Make detailed-status__wrapper actually wrap detailed status (tootsuite#8547)
  Bump i18n-tasks from master to 0.9.28 (tootsuite#9148)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.