Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OEmbed and OpenGraph handling #8669

Merged
merged 1 commit into from Sep 10, 2018

Conversation

@ThibG
Copy link
Collaborator

commented Sep 10, 2018

This fixes #8062 by handling relative URLs in OpenGraph and OEmbed.
It also prefers OpenGraph to OEmbed as the former relies on less HTTP queries, but I don't know if there are reasons to prefer OEmbed anyway when both are available.

@Gargron

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

Preferring OpenGraph to OEmbed

This is very likely a regression. Do YouTube videos still embed? Vimeo? You basically begin to rely on them having the "twitter:player" tag

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2018

@Gargron both seem to still work, but yeah, looking at the code, it might make sense to add a few checks before preferring OpenGraph to OEmbed…

@ThibG ThibG force-pushed the ThibG:fixes/oembed-relative-urls branch from 8458e45 to 8b1a884 Sep 10, 2018

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 10, 2018

Dropped the OpenGraph preference thing.

@Gargron Gargron merged commit bd9e47e into tootsuite:master Sep 10, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 10, 2018
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 12, 2018

@ThibG ThibG deleted the ThibG:fixes/oembed-relative-urls branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.