Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group reports by target account #8674

Merged
merged 2 commits into from Sep 13, 2018

Conversation

@Gargron
Copy link
Member

commented Sep 10, 2018

image

Accounts used in screenshot only for illustration purposes!

@Gargron Gargron force-pushed the feature-reports-overview branch from d9277d6 to 19e81cf Sep 10, 2018
@Shleeble

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

Having the ability to "minimalise" or show/hide an account.. incase one account gets 1000+ reports and I'd want to hide it to find the other reports would be cool.

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2018

I like the idea of grouping reports by target account, but without the table labels, it is slightly less clear who is the reporter and who is the assigned admin. It also seems to take more space per report?

@Gargron

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

It's especially confusing in the screenshot because the admin account is both, but I think in practice seeing mods' names on the right will make it obvious.

It does take more space per report but I think it's balanced as to be clearly readable and skimmable.

@Gargron Gargron merged commit 011437d into master Sep 13, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@Gargron Gargron deleted the feature-reports-overview branch Sep 13, 2018
@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2018

I still think that having no label whatsoever for those columns is confusing.

Also, I'm also wondering whether the paginating makes this too confusing?
Like, if there are very old and very new reports targeting one person, and enough reports in between to make them appear on different pages, you'd think that person would have only been reported recently, unless you go back to the old pages.

@Cassolotl Cassolotl referenced this pull request Sep 19, 2018
1 of 1 task complete
kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018
* Group reports by target account

* Improve CSS
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 10, 2018
* Group reports by target account

* Improve CSS
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 12, 2018
* Group reports by target account

* Improve CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.